Skip to content

Upgrade ChanFs to R0.13a #5490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 30, 2017
Merged

Conversation

deepikabhavnani
Copy link

Upgrading ChanFS, follow link to know more about updates in ChanFS.

#4285

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2017

@deepikabhavnani Can you review jenkins failure. It indicates pal_plat_fileSystem.cpp@600,0: [Pe165]: too few arguments in function call . This is breaking PAL code?

Are any breaking changes expected with this update or should be backward compatible?

@deepikabhavnani
Copy link
Author

PAL is using the ChanFs API (f_mkfs) directly instead of using FATFileSystem::format. It is breaking change from ChanFs, which is not backward compatible.
I am not sure why ChanFs API is used directly, it would be great if that is fixed in cloud client application. Else we can merge this commit in 5.7 release instead of patch.

Copy link
Contributor

@geky geky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks for putting this together 👍

@deepikabhavnani
Copy link
Author

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 16, 2017

Build : SUCCESS

Build number : 536
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5490/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@ARMmbed ARMmbed deleted a comment from mbed-ci Nov 16, 2017
@mbed-ci
Copy link

mbed-ci commented Nov 16, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 17, 2017

PAL is using the ChanFs API (f_mkfs) directly instead of using FATFileSystem::format. It is breaking change from ChanFs, which is not backward compatible.

👍

@avolinski @amiraloosh Can you please review the failures in the jenkins, as quoted above, PAL should use user facing API

@deepikabhavnani
Copy link
Author

Rebased to resolve conflicts

@deepikabhavnani
Copy link
Author

@deepikabhavnani
Copy link
Author

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2017

Build : SUCCESS

Build number : 567
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5490/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2017

@mbed-ci
Copy link

mbed-ci commented Nov 21, 2017

@mbed-ci
Copy link

mbed-ci commented Nov 22, 2017

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2017

@deepikabhavnani I restarted CI again. The last failure from yesterday indicates that the repo was not yet updated. I am failing to see at the moment the hierarchy, going to talk to pal team. Their pal client repo was updated, but not certain if this was also propagated to the client example that failed in the jenkins CI. I'll check

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2017

Update to the latest msg from me: I identified a failure in the logs, @JanneKiiskila and @teetak01 - need your assistance for jenkins CI failure here.

@deepikabhavnani
Copy link
Author

#4285

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 28, 2017

All green ! @deepikabhavnani All ready? :)

@deepikabhavnani
Copy link
Author

Yes.. ready to merge

Copy link
Contributor

@teetak01 teetak01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that this fixes format-related issues present in Mbed OS 5.6.5 (and earlier) for Cloud Client.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 30, 2017

@teetak01 👍 testing appreciated !

@0xc0170 0xc0170 merged commit 8a39773 into ARMmbed:master Nov 30, 2017
@deepikabhavnani deepikabhavnani deleted the fat_upgrade branch November 30, 2017 18:17
@geky geky mentioned this pull request Feb 23, 2018
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants