-
Notifications
You must be signed in to change notification settings - Fork 3k
Upgrade ChanFs to R0.13a #5490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade ChanFs to R0.13a #5490
Conversation
@deepikabhavnani Can you review jenkins failure. It indicates Are any breaking changes expected with this update or should be backward compatible? |
PAL is using the ChanFs API (f_mkfs) directly instead of using FATFileSystem::format. It is breaking change from ChanFs, which is not backward compatible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks for putting this together 👍
0b904f3
to
3961f63
Compare
/morph build |
Build : SUCCESSBuild number : 536 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 152 |
👍 @avolinski @amiraloosh Can you please review the failures in the jenkins, as quoted above, PAL should use user facing API |
3961f63
to
a2a7c28
Compare
Rebased to resolve conflicts |
/morph build |
Build : SUCCESSBuild number : 567 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 180 |
Test : FAILUREBuild number : 382 |
Test : SUCCESSBuild number : 385 |
@deepikabhavnani I restarted CI again. The last failure from yesterday indicates that the repo was not yet updated. I am failing to see at the moment the hierarchy, going to talk to pal team. Their pal client repo was updated, but not certain if this was also propagated to the client example that failed in the jenkins CI. I'll check |
Update to the latest msg from me: I identified a failure in the logs, @JanneKiiskila and @teetak01 - need your assistance for jenkins CI failure here. |
All green ! @deepikabhavnani All ready? :) |
Yes.. ready to merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that this fixes format-related issues present in Mbed OS 5.6.5 (and earlier) for Cloud Client.
@teetak01 👍 testing appreciated ! |
Upgrading ChanFS, follow link to know more about updates in ChanFS.
#4285