littlefs: Update to version 1.3 #6179
Conversation
git-subtree-dir: features/filesystem/littlefs/littlefs git-subtree-split: 5ee20e8
b2124a5 b2124a5 Fixed multiple deploy steps in Travis 949015a Merge pull request ARMmbed#28 from geky/configurables 67daf9e Added cross-compile targets for testing a3fd2d4 Added more configurable utils a0a55fb Added conversion to/from little-endian on disk 4f08424 Added software implementations of bitwise instructions 59ce49f Merge pull request ARMmbed#26 from Sim4n6/master 2f8ae34 Added a git ignore file with .o .d blocks dir and lfs bin e611cf5 Fix incorrect lookahead population before ack a25743a Fixed some minor error code differences 6716b55 Fixed error check when truncating files to larger size 809ffde Merge pull request ARMmbed#24 from aldot/silence-shadow-warnings-1 dc513b1 Silenced more of aldot's warnings aa50e03 Commentary typo fix 6d55755 tests: Silence warnings in template 029361e Silence shadow warnings fd04ed4 Added autogenerated release notes from commits 3101bc9 Do not print command invocation if QUIET d82e34c Merge pull request ARMmbed#21 from aldot/doc-tweaks 436707c doc: Editorial tweaks 3457252 doc: Spelling fixes 6d8e0e2 Moved -Werror flag to CI only 88f678f Fixed self-assign warning in tests 3ef4847 Added remove step in tests to force rebuild f694b14 Merge pull request ARMmbed#16 from geky/versioning 5a38d00 Added deploy step in Travis to push new version as tags 035552a Add version info for software library and on-disk structures 997c2e5 Fixed incorrect reliance on errno in emubd d88f0ac Added lfs_file_truncate 2ad435e Added files test to littlefs-fuse tests in Travis 1fb6a19 Reduced ctz traverse runtime by 2x db88727 Added error code LFS_ERR_NOTEMPTY c2fab8f Added asserts on geometry and updated config documentation 472ccc4 Fixed file truncation without writes aea3d3d Fixed positive seek bounds checking be22d34 Updated links to Mbed OS 425aa3c Fixed issue with immediate exhaustion and small unaligned storage git-subtree-dir: features/filesystem/littlefs/littlefs git-subtree-split: b2124a5
|
@geky Making sure, where are those two merge commits sourced from? |
|
@cmonr, It's a subtree. The mbed-os history is a bit massive, so it's hard to follow, but you can find the subtree's squash branch here: The first merge was a housekeeping commit to move the littlefs subtree from "mbed-os/littlefs" (where it lived in mbed-littlefs) to "mbed-os/features/filesystem/littlefs/littlefs". Which I didn't do correctly when I first added littlefs to mbed-os (#5538). You can find the full history over in the littlefs repo: https://github.com/geky/littlefs/releases Let me know if that helps. |
|
Just to clarify once more: https://github.com/geky/littlefs/commits/master and https://github.com/ARMmbed/mbed-os/commits/master/features/filesystem/littlefs/littlefs both show some recent commits. Any reason, fixes are done separately at both places? |
|
Good question. Most of the development work is happening in https://github.com/geky/littlefs, but any bug fixes are duplicated directly into mbed-os. Additional features and tweaks aren't brought over until a minor release of mbed-os. This way, changes to mbed-os's littlefs match the mbed-os's release model. The mbed-os master should have all of the recent bug fixes without the turmoil of developing new features. |
|
@geky Any reason why the development isn't done in the mbed-os repo, perhaps in a feature branch? |
Merge is expect once every minor release 👍 |
|
It's not an mbed project. Development in the mbed-os is free to do whatever it wants really, subtree merges can handle forked development. The real question is if/how do you want to bring in the changes happening outside of mbed-os. I'm not opposed to also having a feature-branch for littlefs if you want to create one. Though I don't think it would add much value for a project that has no dependencies in mbed-os, and it seems like it would be a pain to maintain. Note this is how we handle other external dependencies such as ChanFS (#5490) and LWIP (#4814). And since the entire code base is still inside mbed-os there's no possibility for foul play. |
Much like the logging functions, assertions can be enabled, disabled and forced with the littlefs.enable_assert config option. Integrates with the new LFS_ASSERT macro.
Enables intrinsics for bit operations such as ctz, popc, and le32 conversion. Can be disabled to help debug toolchain issues. Has proven to be surprisingly useful.
geky
added
needs: review
needs: work
and removed
do not merge
needs: work
needs: review
labels
|
Entertaining: setting CFLAGS="-Werror" causes pip install pyYAML to fail... |
|
Yeah, b28dad6 and 6e67794 are just to update the subtree metadata. They move the littlefs subtree from "mbed-os/littlefs" (where it lived in mbed-littlefs) to "mbed-os/features/filesystem/littlefs/littlefs". I should have done this when first adding littlefs to mbed-os, but I didn't do it correctly. |
|
/morph build |
Build : SUCCESSBuild number : 1303 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 963 |
cmonr
added
needs: CI
release-version: 5.7.7
release-version: 5.8.0-rc1
and removed
needs: review
release-version: 5.7.7
labels
Test : FAILUREBuild number : 1087 |
|
/morph build |
Build : SUCCESSBuild number : 1309 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 969 |
Test : FAILUREBuild number : 1093 |
|
@deepikabhavnani @kegilbert please re-review. |
|
Good news, the original test failure was fixed, bad news, this failure is completely unrelated to this PR. @adbridge, @studavekar, have you seen other nrf52_dk flash failures? Maybe the board's flash died... |
|
@geky can you go talk to @studavekar directly please and get him to test the board. We are running out of time if this needs to go into 5.8 |
May be related to failure which we seeing on #6224 |
Test : SUCCESSBuild number : 1099 |
Exporter Build : FAILUREBuild number : 1527 |
What's new?
Changes
b2124a5Fixed multiple deploy steps in Travis67daf9eAdded cross-compile targets for testinga3fd2d4Added more configurable utilsa0a55fbAdded conversion to/from little-endian on disk4f08424Added software implementations of bitwise instructions2f8ae34Added a git ignore file with .o .d blocks dir and lfs bine611cf5Fix incorrect lookahead population before acka25743aFixed some minor error code differences6716b55Fixed error check when truncating files to larger sizedc513b1Silenced more of aldot's warningsaa50e03Commentary typo fix6d55755tests: Silence warnings in template029361eSilence shadow warningsfd04ed4Added autogenerated release notes from commits3101bc9Do not print command invocation if QUIET436707cdoc: Editorial tweaks3457252doc: Spelling fixes6d8e0e2Moved -Werror flag to CI only88f678fFixed self-assign warning in tests3ef4847Added remove step in tests to force rebuild5a38d00Added deploy step in Travis to push new version as tags035552aAdd version info for software library and on-disk structures997c2e5Fixed incorrect reliance on errno in emubdd88f0acAdded lfs_file_truncate2ad435eAdded files test to littlefs-fuse tests in Travis1fb6a19Reduced ctz traverse runtime by 2xdb88727Added error code LFS_ERR_NOTEMPTYc2fab8fAdded asserts on geometry and updated config documentation472ccc4Fixed file truncation without writesaea3d3dFixed positive seek bounds checkingbe22d34Updated links to Mbed OS425aa3cFixed issue with immediate exhaustion and small unaligned storageTODO
Integrate lfs_file_truncate?Additional notes
related #5653
cc @deepikabhavnani, @kegilbert, @0xc0170
code size 10108B
intended for minor release