-
Notifications
You must be signed in to change notification settings - Fork 3k
Travis: Tear out python3 testing to get CI working again #6218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Temporary solution, python3 will be added back later Travis doesn't recognize version matrices when inside a matrix include job. Instead, it breaks in a way that isn't reported as an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better than doing nothing silently.
/morph build |
Build : SUCCESSBuild number : 1262 Triggering tests/morph test |
@cmonr, sorry it's not ready yet. Now, travis fails successfully, but we need to fix the tools so it does not. |
@geky Oh, my mistake. Was under the impression that the quick fix was ready. In that case, LMK when it is. |
Exporter Build : FAILUREBuild number : 927 |
Bugs introduced while broken:
|
#6096 did not have to add the offending line; it added nothing. |
The first error is a unicode problem XD notice the |
Test : SUCCESSBuild number : 1059 |
@theotherjimmy - offending line was a suggestion from your side to get the path of build directory, which is used few steps below. Will appreciate to have proper fix from your side, to append the build directory path for cmse_lib.o creation. |
I added some fixes/workarounds, @theotherjimmy, @deepikabhavnani, if you could review and let me know if you're happy with these for now.
Haha, it's not even a real unicode error. It's just that now the config will show that "u" when it has errors, and the tests are checking the error strings.
@deepikabhavnani, I moved the |
@geky That workaround works, but I would prefer that the offending test just pass in a dummy |
@theotherjimmy - Can you please confirm build_dir will not be Toolchain init is different for ARM / ARMC6, will this have any impact? Ok, i was late :-) |
@deepikabhavnani Build dir being None is an error. We need a place to put object files. |
@geky Feel free to delete the |
It added value at one point, but no longer. |
962be07
to
f88536c
Compare
/morph build |
Build : SUCCESSBuild number : 1266 Triggering tests/morph test |
Test : SUCCESSBuild number : 1063 |
Exporter Build : SUCCESSBuild number : 932 |
Also moved the access of build_dir into condition on secure in ARMC6 per theotherjimmy
f88536c
to
24bb556
Compare
@cmonr, sorry for the slip up. Should be good to go now (heavy handed solution). I moved the build dir back into the condition. It looks like none of the other tests pass in build_dir either, but the root of this problem can be fixed in another pr. |
/morph build |
Build : SUCCESSBuild number : 1286 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 949 |
Test : SUCCESSBuild number : 1075 |
Reverting a change that only went in for 5.8 so should have also targeted that release! In fact as this was merged prior to 5.8 rc1 it should already be in that release |
Temporary solution, python3 will be added back when working (see #6200)
Travis doesn't recognize version matrices when inside a matrix include job. Instead, it breaks in a way that isn't reported as an error.
cc @theotherjimmy, @0xc0170, @deepikabhavnani, @cmonr
intended for patch
introduced in #5848
related travis-ci/travis-ci#9275