Release candidate for mbed-os-5.7.2 #5767

@bulislaw
Looks like #5342 broke mbed 2
It went into 5.7.1 but as we have been having problems with mbed2 releases we didn't run the mbed2 build against 5.7.1 !

10:55:27         [Fatal Error] irq_ctrl_gic.c@27,19: cmsis.h: No such file or directory
10:55:27         [DEBUG] Return: 1
10:55:27         [DEBUG] Output: /home/jenkins/mbed_jenkins_node2/workspace/bm_wrap/1667/mbed-os/cmsis/TARGET_CORTEX_A/irq_ctrl_gic.c:27:19: fatal error: cmsis.h: No such file or directory
10:55:27         [DEBUG] Output:  #include <cmsis.h>
10:55:27         [DEBUG] Output:                    ^
10:55:27         [DEBUG] Output: compilation terminated.
10:55:27         /home/jenkins/mbed_jenkins_node2/workspace/bm_wrap/1667/mbed-os/cmsis/TARGET_CORTEX_A/irq_ctrl_gic.c:27:19: fatal error: cmsis.h: No such file or directory
10:55:27          #include <cmsis.h>
10:55:27                            ^

This is a blocker for 5.7.2 please investigate asap!

mbed-ci · 2017-12-29T17:31:40Z

Exporter Build : SUCCESS

Build number : 425
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5767/

mbed-ci · 2017-12-29T19:06:55Z

Test : SUCCESS

Build number : 607
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5767/607

cmonr · 2017-12-29T20:40:06Z

@adbridge A quick fix would be to outright disable the export of the target in targets.json by blanking out the release_versions array for both A9 targets.

As for the actual issue, it looks like the file is relying on device-specific information, which seems backwards to what files in the cmsis directory should be doing.

0xc0170 · 2017-12-29T21:37:56Z

As for the actual issue, it looks like the file is relying on device-specific information, which seems backwards to what files in the cmsis directory should be doing.

This change comes from:
https://github.com/ARM-software/CMSIS_5/blob/5231d567ea7446e022504d8b438ce3428912419c/CMSIS/Core_A/Source/irq_ctrl_gic.c

At the moment we do not have RTE component, neither CMSIS_device_header set up, thus cmsis.h used there instead. The file is actually there: https://github.com/ARMmbed/mbed-os/blob/master/targets/TARGET_RENESAS/TARGET_RZ_A1H/device/cmsis.h.

I am more wondering why <cmsis.h> is used and not "cmsis.h" in this case. That might fix this issue

Update: build tools have cmsis path, no target path involved, this is why it fails

0xc0170 · 2018-01-02T08:17:50Z

#5770 should fix the issue

Pending official update from STM, add memory barriers to the Ethernet HAL code for the STM32F7xx family. Cortex-M7 has a merging write buffer that is not automatically flushed by accesses to devices, so without these DMBs, we sometimes lose synch with the transmitter. The DMBs are architecturally needed in every version of this HAL, but adding just to the STM32F7 version for now to clear test, as the problem has only been observed on Cortex-M7-based devices. Fixes #5622.

The K64F Ethernet driver installs an interrupt handler that sets thread flags, and this could be called before the thread was initialised, so it would use a NULL thread ID. This triggers an RTX error-checking trap in debug builds, and could also lead to other problems with received packets not being processed. Adjusted so the RX interrupt handler does nothing if the thread isn't initialised yet, and manually trigger a RX event flag after initialising the thread in case any interrupts were ignored. An alternative would have been to implement eth_arch_enable_interrupts, but this mechanism is not present in the EMAC world - drivers will have to start returning interrupts in their power up. Fixes #5680

Fix by Jimmy

When specifying a full channel mask in .lib and setting the channel to zero, device does proper channel scan. For Thread, channel must be specified for router. Sleepy devices don't respect the channel settings but do a full channel scan at the start. + Modified the channel mask print to use hex.

- ADuCM3029 is the MCU name for EV_COG_AD3029LZ - ADuCM4050 is the MCU name for EV_COG_AD4050LZ

For supporting tp CMSIS5/RTX5, I changed the start-up processing of 3 toolchains(ARMCC, GCC_ARM, IAR) and updated the register definition of PEACH specific. In addition, I changed the linker script files to implement the dynamic HEAP the same as Cortex-M targets.Since GR-PEACH's HEAP was a fixed area, I changed the label name(ZI_DATA to RW_IRAM1) and replaced the allocation of STACK/HEAP.

By updating to the codes of CMSIS5/RTX5, GIC_SetConfigration() function was added for Cortex-A, this function is set the interrupt configuration using GIC's ICFGR register. Therefore, I added this function to satisfy Cortex-A interrupt spec in the below files. "can_api.c", "ethernet_api.c", "gpio_irq_api.c", "i2c_api.c", "spi_api.c" and "us_ticker.c"

I added the below definitions for working "Dynamic Stack" and "Dynamic heap" on Mbed OS by referencing with the codes of Cortex-M target board. "ISR_STACK_START", "ISR_STACK_SIZE", "INITIAL_SP", "HEAP_START" and "HEAP_SIZE"

I changed disable_irq() / enable_irq() to core_util_critical_section_enter() / core_util_critical_section_exit() by utilizing "mbed_critical" function in the below drivers. - serial_api.c - us_ticker.c

Although the extened RTC is supported by #5363 commit ("Add support and tests for extended RTC"), it seems that the changes was overlooked in RZ_A1H_api.c. So I added the changes with reference to other rtc_api.c.

I changed the python and json files to re-registering GR-PEACH to Mbed OS 5.

I added the definition of "Cortex-A9" for core support of ARMCC and ARMC6 in arm.py.

I modified "space" character from 2-byte code to 1-byte code in "heap and stack" test main.

"malloc" test is used a simple thread that executes only malloc and free, but it seems that there is a difference in the stack used between Cortex-A and Cortex-M. As a result of check, in Cortex-A, program aborts because of the lack of stack when THREAD_STACK_SIZE is 256, workes properly when THREAD_STACK_SIZE is 512 at least. Since it seems that the definition processing of "DEFAULT_STACK_SIZE" was gone from Mbed OS by updating CMSIS5/RTX5, I setted 512 directly for Cortex-A.

Impossible to make USBHost working on this board. Remove it for now until a fix is found.

Most of our IP stacks don't allow removal of interfaces so interface destructor can not reliably clean up. Therefore we cannot rely its behaviours in test case. Instead run interface->disconnect() in case interface was already created.

As this is os tick implementation for rtos, it should not be compilied if rtos not present (mbed 2)

Travis: dsp only for cortex-m

Build api used to build cmsis separately (how mbed 2 is being build). This is currently not how cmsis is being defined. As there target dependencies in some cases, we should include paths from targets when building cmsis

Use mbed critical section

As it does not share the codebase with RZ A1H, it needs to be disabled until bring it up to date with the latest changes to cmsis. There are changes regarding caches, mmu and others

adbridge · 2018-01-02T15:23:55Z

/morph mbed2-release

adbridge · 2018-01-02T15:24:04Z

/morph build

mbed-bot · 2018-01-02T15:40:26Z

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

Output

mbed Build Number: 73

Build failed!

mbed-ci · 2018-01-02T15:56:39Z

Build : FAILURE

Build number : 776
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5767/

This reverts commit 1bb2ca6.

adbridge · 2018-01-02T16:31:43Z

The commit reverted above , causes conflicts with changes made which are currently targeted for 5.8, (#5363 ), reverting this one commit allows us to bring in #5628

adbridge · 2018-01-02T16:32:14Z

/morph mbed2-release

adbridge · 2018-01-02T16:32:23Z

/morph build

mbed-bot · 2018-01-02T16:59:53Z

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph mbed2-release

mbed-ci · 2018-01-02T17:01:49Z

Build : SUCCESS

Build number : 777
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5767/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-02T17:52:18Z

Exporter Build : FAILURE

Build number : 429
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5767/

mbed-ci · 2018-01-02T18:24:29Z

Test : SUCCESS

Build number : 612
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5767/612

0xc0170 · 2018-01-02T18:28:22Z

/morph export-build

mbed-ci · 2018-01-02T18:46:58Z

Build : SUCCESS

Build number : 780
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5767/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

mbed-ci · 2018-01-02T19:05:56Z

Exporter Build : ABORTED

Build number : 432
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5767/

studavekar · 2018-01-02T19:08:16Z

Exporter Build : ABORTED

Build number : 432
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5767/

This was aborted by mistake, though there was a duplicate job. I have added it back in queue.

mbed-ci · 2018-01-02T19:36:25Z

Exporter Build : SUCCESS

Build number : 433
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5767/

adbridge force-pushed the release-candidate branch from ea66503 to 7d2675c Compare December 29, 2017 16:34

kjbracey and others added 17 commits January 2, 2018 15:22

Build failed as code section was not included in map.

815b9bf

Fix by Jimmy

Add mbed-os-example-filesystem to examples list

0923e8f

Enable IAR export for EV_COG_AD3029LZ and EV_COG_AD4050LZ

f99ec6b

- ADuCM3029 is the MCU name for EV_COG_AD3029LZ - ADuCM4050 is the MCU name for EV_COG_AD4050LZ

Add app_start config system support for NRF52840 for bootloader

bbb6372

RTX5: Cortex-A exception handlers updated (VFP register count detection)

668883a

Add the lacked definitions to mbed_rtx.h

747138f

I added the below definitions for working "Dynamic Stack" and "Dynamic heap" on Mbed OS by referencing with the codes of Cortex-M target board. "ISR_STACK_START", "ISR_STACK_SIZE", "INITIAL_SP", "HEAP_START" and "HEAP_SIZE"

Change the way of enter/exit of critical section of code

c29772a

I changed disable_irq() / enable_irq() to core_util_critical_section_enter() / core_util_critical_section_exit() by utilizing "mbed_critical" function in the below drivers. - serial_api.c - us_ticker.c

Supplement the lack of "extended RTC" in RZ_A1H/rtc_api.c

67781c2

Although the extened RTC is supported by #5363 commit ("Add support and tests for extended RTC"), it seems that the changes was overlooked in RZ_A1H_api.c. So I added the changes with reference to other rtc_api.c.

Revert "Remove Cortex-A mbed OS 5 support"

709d9ee

I changed the python and json files to re-registering GR-PEACH to Mbed OS 5.

Add Cortex-A9 for ARMCC and ARMC6

9bc8a36

I added the definition of "Cortex-A9" for core support of ARMCC and ARMC6 in arm.py.

Modify 2-byte code of "heap and stack" test main for Cortex-A

edc0b18

I modified "space" character from 2-byte code to 1-byte code in "heap and stack" test main.

bcostm and others added 11 commits January 2, 2018 15:22

STM32 USBHOST: Remove DISCO_F429ZI

177c95b

Impossible to make USBHost working on this board. Remove it for now until a fix is found.

Access to serial device is allowed when DEVICE_SERIAL is defined

68da43c

Remove destruction of WiFi interface in test runs

bbe11de

Most of our IP stacks don't allow removal of interfaces so interface destructor can not reliably clean up. Therefore we cannot rely its behaviours in test case. Instead run interface->disconnect() in case interface was already created.

Added init for ODIN EVK LEDs to be off by default

d95a253

Added license header

404e8ed

renesas: os tick only for rtos

a83068c

As this is os tick implementation for rtos, it should not be compilied if rtos not present (mbed 2)

Travis: add RZ_A1H target

89bc1a2

Travis: dsp only for cortex-m

tools: cmsis and hal are build together

7327e8e

Build api used to build cmsis separately (how mbed 2 is being build). This is currently not how cmsis is being defined. As there target dependencies in some cases, we should include paths from targets when building cmsis

VK RZ A1H: fix errors from the latest cmsis updates

54d12c8

Use mbed critical section

VK RZ A1H: remove target from mbed 2 release

97a61c4

As it does not share the codebase with RZ A1H, it needs to be disabled until bring it up to date with the latest changes to cmsis. There are changes regarding caches, mmu and others

Update Mbed version block for patch release

37641d7

adbridge force-pushed the release-candidate branch from 7d2675c to 37641d7 Compare January 2, 2018 15:22

Revert "Supplement the lack of "extended RTC" in RZ_A1H/rtc_api.c"

431b2d1

This reverts commit 1bb2ca6.

0xc0170 merged commit eca67ca into mbed-os-5.7 Jan 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release candidate for mbed-os-5.7.2 #5767

Release candidate for mbed-os-5.7.2 #5767

adbridge commented Dec 29, 2017

adbridge commented Dec 29, 2017

adbridge commented Dec 29, 2017

mbed-bot commented Dec 29, 2017

studavekar commented Dec 29, 2017

mbed-ci commented Dec 29, 2017

mbed-bot commented Dec 29, 2017

adbridge commented Dec 29, 2017 •

edited

Loading

mbed-ci commented Dec 29, 2017

mbed-ci commented Dec 29, 2017

cmonr commented Dec 29, 2017

0xc0170 commented Dec 29, 2017 •

edited

Loading

0xc0170 commented Jan 2, 2018

adbridge commented Jan 2, 2018

adbridge commented Jan 2, 2018

mbed-bot commented Jan 2, 2018

mbed-ci commented Jan 2, 2018

adbridge commented Jan 2, 2018

adbridge commented Jan 2, 2018

adbridge commented Jan 2, 2018

mbed-bot commented Jan 2, 2018

mbed-ci commented Jan 2, 2018

mbed-ci commented Jan 2, 2018

mbed-ci commented Jan 2, 2018

0xc0170 commented Jan 2, 2018

mbed-ci commented Jan 2, 2018

mbed-ci commented Jan 2, 2018

studavekar commented Jan 2, 2018

Exporter Build : ABORTED

mbed-ci commented Jan 2, 2018

Release candidate for mbed-os-5.7.2 #5767

Release candidate for mbed-os-5.7.2 #5767

Conversation

adbridge commented Dec 29, 2017

adbridge commented Dec 29, 2017

adbridge commented Dec 29, 2017

mbed-bot commented Dec 29, 2017

studavekar commented Dec 29, 2017

mbed-ci commented Dec 29, 2017

Triggering tests

mbed-bot commented Dec 29, 2017

Output

adbridge commented Dec 29, 2017 • edited Loading

mbed-ci commented Dec 29, 2017

mbed-ci commented Dec 29, 2017

cmonr commented Dec 29, 2017

0xc0170 commented Dec 29, 2017 • edited Loading

0xc0170 commented Jan 2, 2018

adbridge commented Jan 2, 2018

adbridge commented Jan 2, 2018

mbed-bot commented Jan 2, 2018

Output

mbed-ci commented Jan 2, 2018

adbridge commented Jan 2, 2018

adbridge commented Jan 2, 2018

adbridge commented Jan 2, 2018

mbed-bot commented Jan 2, 2018

mbed-ci commented Jan 2, 2018

Triggering tests

mbed-ci commented Jan 2, 2018

mbed-ci commented Jan 2, 2018

0xc0170 commented Jan 2, 2018

mbed-ci commented Jan 2, 2018

Triggering tests

mbed-ci commented Jan 2, 2018

studavekar commented Jan 2, 2018

mbed-ci commented Jan 2, 2018

adbridge commented Dec 29, 2017 •

edited

Loading

0xc0170 commented Dec 29, 2017 •

edited

Loading