Reregistration GR-PEACH as mbed support board #5628

TomoYamanaka · 2017-12-01T04:57:31Z

Description

By #5342, since Cortex-A was supported wtih updating CMSIS/RTX, I request that GR-PEACH is registed as mbed board again.

I've closed #5530, because I removed my commits accidently. So, I made this PR again.

The main changes is the below.

Changes to PEACH code (4 commits)
Changes to Mbed OS including to reverting "disabling the Cortex-A" (5 commits)
Cherry-picked changes from CMSIS/RTX repo (3 commits)
New changes to CMSIS/RTX (3 commits)

Request

I strongly desire to be included in the shortest release package after completing the merge of this PR.

@toyowata
Please help me to go ahead with the above.

0xc0170 · 2017-12-01T09:40:45Z

I looked at the changes (changes to target code looks fine to me). Got question regarding changes to CMSIS/RTX.

The last 3 commits - are they going also upstream (are there pull requests or issues reported) ?

3 commits that are being cherry-picked from CMSIS repository, they are already released (what version), or develop branch ? To be aware, what update do we need to get these in.

bulislaw · 2017-12-01T09:56:06Z

@JonatanAntoni could you review this 3 commits, as if they would be submitted to CMSIS_5 repo:
c6fa97c
c91b39a
aaad6c1

bulislaw · 2017-12-01T09:57:19Z

cmsis/TARGET_CORTEX_A/core_ca.h

@@ -1788,6 +1788,20 @@ typedef struct RegionStruct {
                                   region.sh_t = NON_SHARED; \
                                   MMU_GetSectionDescriptor(&descriptor_l1, region);

+#define section_normal_nc(descriptor_l1, region)     region.rg_t = SECTION; \


Just looking at the different macros this one is missing documentation

TomoYamanaka · 2017-12-08T08:44:23Z

@bulislaw @JonatanAntoni
For merge the changes(0421868, fefec98, e2acfc1) of CMSIS/RTX, I has been promoted discussion by giving three PR to CMSIS_5 repo.
Currently, one of three(#286) was merged in CMSIS repo, but rest requests(#287, #288) do not be still merged and discussion is continuing. It seems that the cause and my changing contents obtained a certain understanding, now discussion focus on permanent fix. I think that permanent fix is needed, however, I strongly desire to merge this PR to Mbed OS 5.7 that will mention "cortex-A suppport" as official.

Therefore, Could you please merge my changes of CMSIS/RTX as tentative?
Of course, if permanent fix was completed in CMSIS_5 repo, I will cherry-pick them.

@toyowata
Please help me to go ahead with the above.

0xc0170 · 2017-12-08T10:46:10Z

For merge the changes(0421868, fefec98, e2acfc1) of CMSIS/RTX, I has been promoted discussion by giving three PR to CMSIS_5 repo.

Thank you 👍

Currently, one of three(#286) was merged in CMSIS repo, but rest requests(#287, #288) do not be still merged and discussion is continuing. It seems that the cause and my changing contents obtained a certain understanding, now discussion focus on permanent fix. I think that permanent fix is needed, however, I strongly desire to merge this PR to Mbed OS 5.7 that will mention "cortex-A suppport" as official.

Based on the review for those opened 2 PR, and discussion with @JonatanAntoni. There's only one left, 288 was fixed , so that could be done here the same (cosmetic change there the functionality the same). Thus only 287 needs further validation. Please help there to validate.

Thus only one remaining, that is not blocking this PR to my understanding.

What I would like to have one documentation improvement, New changes to CMSIS/RTX (No 1 of total 3 commits) The headline for each commit should provide meaningful information to a reader within 50 characters. If you could rework the commit messages it would be helpful. For instance: New changes to CMSIS/RTX (No 1 of total 3 commits) this could be CMSIS: add section_normal_nc impl or similar then the paragraph below is good as you have it 👍 The rest should follow. Once this is done, let us know

TomoYamanaka · 2017-12-11T11:32:42Z

@0xc0170
Thank you for your comments.
I rebased those commits in the form of changing commit message.

Based on the review for those opened 2 PR, and discussion with @JonatanAntoni. There's only one left, 288 was fixed , so that could be done here the same (cosmetic change there the functionality the same). Thus only 287 needs further validation. Please help there to validate.

286 and 288 were fixed in CMSIS_5 repo so that I cherry-picked those two commits(5f850a2 , 839e4a5).
Also since only 287 needs further validation, I didn't cherry-pick, and changed only the commit message.

Please let me know if there is anything you are unclear.

toyowata · 2017-12-13T07:25:14Z

@0xc0170 Any additional step required for this PR?

0xc0170 · 2017-12-13T10:15:40Z

@TomoYamanaka If you can please rebase, we will trigger tests

@bulislaw Please review

TomoYamanaka · 2017-12-14T12:19:00Z

@0xc0170 @toyowata

I rebased those commits.

TomoYamanaka · 2017-12-18T01:54:30Z

How is going? Is there anything else to do?

0xc0170

The only commit I do not fully understand is c6827c8854604d45ee3b32f49adddddaab252efa - changing linker script files, not enough information in the commit msg to understand why bss section was changed and other sections there

0xc0170 · 2017-12-18T08:23:29Z

/morph build

mbed-ci · 2017-12-18T08:53:17Z

Build : FAILURE

Build number : 711
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5628/

0xc0170 · 2017-12-18T08:54:59Z

It seems our CI got a license problem (only some devices, seems like CI networking failure rather), will investigate

cc @studavekar @kegilbert

TomoYamanaka · 2017-12-18T10:41:01Z

@0xc0170
I changed the linker script files to implement the dynamic HEAP the same as Cortex-M targets.
Since GR-PEACH's HEAP was a fixed area, I changed the label name(ZI_DATA to RW_IRAM1) and replaced the allocation of STACK/HEAP.

Do you know what I mean?
If there is no problem in this description, I will update the commit message soon.

TomoYamanaka · 2017-12-18T11:20:13Z

@0xc0170
Thank you. I updated the commit msg.

bulislaw · 2017-12-19T08:56:35Z

@TomoYamanaka we still have two commits touching CMSIS/RTX code:
a888ca5
4d85759

Where are we with pushing them to the original CMSIS/RTX repo?

TomoYamanaka · 2017-12-19T09:39:15Z

@bulislaw

a888ca5
I cherry-picked this commit from CMSIS_5 repo.
4d85759
I don't cherry-pick this commit from CMSIS_5 repo.
I aim to merge this PR to Mbed OS 5.7, so I discussed with Arm Mbed team member on the thread and agreed with them to merge this commit as a tentative.

JonatanAntoni · 2017-12-19T10:09:10Z

@TomoYamanaka,

4d85759 should have been superseded by 17b53ef2, bd0db8d and d43938f.

Cheers,
Jonatan

TomoYamanaka · 2017-12-19T10:54:40Z

@JonatanAntoni

I rebased the commit 4d85759 by cherry-pick those commits(17b53ef2 , d43938f).

bulislaw · 2017-12-19T12:30:09Z

@TomoYamanaka

4d85759
I don't cherry-pick this commit from CMSIS_5 repo.
I aim to merge this PR to Mbed OS 5.7, so I discussed with Arm Mbed team member on the thread and agreed with them to merge this commit as a tentative.

Could you point me to the comment?

- Added L1 Cache test cases to CoreValidation. - Adopted FVP Cortex-A configs to simulate cache states.

…ed#287) __DEPRECATED conflicts with a predefined macro in GCC C++ mode.

TomoYamanaka · 2017-12-21T05:13:49Z

@0xc0170
I rebased those commits. Is this ok with you?

bulislaw · 2017-12-21T16:30:45Z

/morph build

mbed-ci · 2017-12-21T16:47:39Z

Build : FAILURE

Build number : 741
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5628/

bulislaw · 2017-12-22T08:24:47Z

Arm compiler licence issues - retry.

/morph build

mbed-ci · 2017-12-22T08:53:45Z

Build : SUCCESS

Build number : 748
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5628/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build

0xc0170 · 2017-12-22T09:18:29Z

Restarted uvisor job (flash failure). mbed-os-generic-context - to be resolved, should not be here

mbed-ci · 2017-12-22T09:33:43Z

Exporter Build : SUCCESS

Build number : 401
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/5628/

mbed-ci · 2017-12-22T10:07:56Z

Test : SUCCESS

Build number : 573
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5628/573

0xc0170 · 2017-12-22T10:20:10Z

@orenc17A Can you help resolving an error in uvisor CI?

orenc17 · 2017-12-23T11:51:14Z

/morph uvisor-test

toyowata · 2017-12-27T04:57:32Z

@0xc0170 Can you merge this please?

bulislaw · 2017-12-27T17:31:13Z

@0xc0170 @theotherjimmy

adbridge · 2017-12-29T16:29:21Z

This relies on previous changes targeted for 5.8 so should also go to that minor release.

0xc0170 · 2018-01-02T14:53:58Z

This relies on previous changes targeted for 5.8 so should also go to that minor release.

Please provide reference of offending dependencies.

adbridge · 2018-01-02T15:18:04Z

Having done a re-run this is now patching across ok. Not sure why it was failing before unless it was conflicting with another PR which may have also been removed!

0xc0170 added the needs: review label Dec 1, 2017

0xc0170 requested a review from bulislaw December 1, 2017 08:05

bulislaw reviewed Dec 1, 2017

View reviewed changes

TomoYamanaka force-pushed the master branch from aaad6c1 to e2acfc1 Compare December 1, 2017 11:03

toyowata mentioned this pull request Dec 6, 2017

Misleading output about VK_RZ_A1H and RZ_A1H in 5.7 ARMmbed/mbed-os-example-blinky#99

Closed

TomoYamanaka force-pushed the master branch from e2acfc1 to 1da2941 Compare December 11, 2017 11:06

0xc0170 approved these changes Dec 11, 2017

View reviewed changes

TomoYamanaka force-pushed the master branch from 1da2941 to b97a43c Compare December 14, 2017 12:16

0xc0170 approved these changes Dec 18, 2017

View reviewed changes

TomoYamanaka force-pushed the master branch from b97a43c to 4d85759 Compare December 18, 2017 11:17

TomoYamanaka force-pushed the master branch from 4d85759 to 1dda366 Compare December 19, 2017 10:46

VladimirUmek and others added 3 commits December 21, 2017 14:09

RTX5: fixed __get_PSP function for Cortex-A on IAR (ARMmbed#288)

0ff62f6

Core(A): Refactored L1 Cache maintenance to be compiler agnostic.

2f06202

- Added L1 Cache test cases to CoreValidation. - Adopted FVP Cortex-A configs to simulate cache states.

Core(A): Changed macro __DEPRECATED to CMSIS_DEPRECATED. (Issue ARMmb…

063717d

…ed#287) __DEPRECATED conflicts with a predefined macro in GCC C++ mode.

TomoYamanaka force-pushed the master branch from 1dda366 to 063717d Compare December 21, 2017 05:10

cmonr added release-version: 5.7.2 and removed needs: CI labels Dec 28, 2017

cmonr merged commit 2b718fe into ARMmbed:master Dec 28, 2017

adbridge added release-version: 5.8.0-rc1 and removed release-version: 5.7.2 labels Dec 29, 2017

adbridge added release-version: 5.7.2 and removed release-version: 5.8.0-rc1 labels Jan 2, 2018

adbridge mentioned this pull request Jan 2, 2018

Release candidate for mbed-os-5.7.2 #5767

Merged

TomoYamanaka mentioned this pull request Jan 4, 2018

VK RZ A1H: needs an update from RZ A1H (cmsis, rtos related) #5777

Closed

TomoYamanaka mentioned this pull request Jan 16, 2018

Registration GR-LYCHEE board as a new mbed board #5857

Merged

TomoYamanaka mentioned this pull request May 24, 2018

Support Flash iAP and Bootloader for GR-PEACH and GR-LYCHEE #6925

Merged

Reregistration GR-PEACH as mbed support board #5628

Reregistration GR-PEACH as mbed support board #5628

Conversation

TomoYamanaka commented Dec 1, 2017 • edited Loading

Description

Request

0xc0170 commented Dec 1, 2017

bulislaw commented Dec 1, 2017

bulislaw Dec 1, 2017

Choose a reason for hiding this comment

TomoYamanaka commented Dec 8, 2017

0xc0170 commented Dec 8, 2017 • edited Loading

TomoYamanaka commented Dec 11, 2017

toyowata commented Dec 13, 2017

0xc0170 commented Dec 13, 2017 • edited Loading

TomoYamanaka commented Dec 14, 2017

TomoYamanaka commented Dec 18, 2017

0xc0170 left a comment

Choose a reason for hiding this comment

0xc0170 commented Dec 18, 2017

mbed-ci commented Dec 18, 2017

Build : FAILURE

0xc0170 commented Dec 18, 2017 • edited Loading

TomoYamanaka commented Dec 18, 2017

TomoYamanaka commented Dec 18, 2017

bulislaw commented Dec 19, 2017

TomoYamanaka commented Dec 19, 2017 • edited Loading

JonatanAntoni commented Dec 19, 2017 • edited Loading

TomoYamanaka commented Dec 19, 2017

bulislaw commented Dec 19, 2017

TomoYamanaka commented Dec 21, 2017 • edited Loading

bulislaw commented Dec 21, 2017

mbed-ci commented Dec 21, 2017

Build : FAILURE

bulislaw commented Dec 22, 2017

mbed-ci commented Dec 22, 2017

Build : SUCCESS

Triggering tests

0xc0170 commented Dec 22, 2017

mbed-ci commented Dec 22, 2017

Exporter Build : SUCCESS

mbed-ci commented Dec 22, 2017

Test : SUCCESS

0xc0170 commented Dec 22, 2017

orenc17 commented Dec 23, 2017

toyowata commented Dec 27, 2017

bulislaw commented Dec 27, 2017

adbridge commented Dec 29, 2017

0xc0170 commented Jan 2, 2018

adbridge commented Jan 2, 2018

TomoYamanaka commented Dec 1, 2017 •

edited

Loading

0xc0170 commented Dec 8, 2017 •

edited

Loading

0xc0170 commented Dec 13, 2017 •

edited

Loading

0xc0170 commented Dec 18, 2017 •

edited

Loading

TomoYamanaka commented Dec 19, 2017 •

edited

Loading

JonatanAntoni commented Dec 19, 2017 •

edited

Loading

TomoYamanaka commented Dec 21, 2017 •

edited

Loading