Support Flash iAP and Bootloader for GR-PEACH and GR-LYCHEE #6925

TomoYamanaka · 2018-05-16T08:10:15Z

Description

Renesas added flash iap and bootloader feature to GR-PEACH and GR-LYCHEE.

Flash iAP was successful by tests-mbed_drivers-flashiap and tests-mbed_hal-flash.
Also Those was tested with https://github.com/ARMmbed/mbed-os-example-bootloader and was successful.

Pull request type

[ ] Fix
[ ] Refactor
[x] New target
[ ] Feature
[ ] Breaking change

0xc0170 · 2018-05-20T16:11:35Z

/morph build

mbed-ci · 2018-05-20T17:53:40Z

Build : FAILURE

Build number : 2073
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6925/

0xc0170 · 2018-05-20T21:17:25Z

@TomoYamanaka Please review the build failures

TomoYamanaka · 2018-05-21T09:48:18Z

I rebased my commits due to address the build failure.

cmonr

👍

cmonr · 2018-05-21T15:54:11Z

/morph build

mbed-ci · 2018-05-21T19:58:50Z

Build : SUCCESS

Build number : 2086
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6925/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-05-22T00:42:28Z

Test : SUCCESS

Build number : 1897
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6925/1897

mbed-ci · 2018-05-22T02:41:51Z

Exporter Build : FAILURE

Build number : 1730
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6925/

0xc0170 · 2018-05-22T11:17:18Z

Please review exporter failure. There are multiple warnings for redefinition (that would be nice to be fixed), but more importantly here - 3 failures reported for ARMCC

TomoYamanaka · 2018-05-23T02:51:13Z

Exporter occurs failure only IAR according the above report, so I modified the IAR definition for export.

TomoYamanaka · 2018-05-24T02:59:29Z

With respect to the error message of Exporter for UVISION,

assembling irq_ca.S...
irq_ca.S: Error:  #5: cannot open source input file "__UVISION_VERSION SETA 521": No such file or directory
irq_ca.S: __UVISION_VERSION SETA 521: 0 warnings, 1 errorirq_ca.S: Error: A1067E: Output file specified as 'mbed-os\rtos\TARGET_CORTEX\rtx5\RTX\Source\TOOLCHAIN_ARM\TARGET_CORTEX_A\irq_ca.S', but it has already been specified as '.\build\irq_ca.o'
irq_ca.S: error: A1905U: Pre-processor step failed for '__UVISION_VERSION SETA 521'

I don' know why the message is outputed.
The specified file is out of this time's changes renge, and I cannot find "__UVISION_VERSION SETA 521" file into mbed-os repo.
mbed-os\rtos\TARGET_CORTEX\rtx5\RTX\Source\TOOLCHAIN_ARM\TARGET_CORTEX_A\irq_ca.S

Previously, although I updated this file for RTX5 update by cherry-picking from CMSIS_5 repo, I did not change it since then.
this error did not outputed in the PR of its updating.
#5628 (comment)

@toyowata Please help me to go ahead with the above.

TomoYamanaka · 2018-06-18T07:02:07Z

I will appreciate if you can accelerate the resolution because this is a blocker for Renesas user's activity.

cmonr · 2018-06-19T18:59:22Z

@TomoYamanaka It is high in my queue of work to get a PR in that will allow this to pass CI. Once that PR is made, I'll link it here.

cmonr · 2018-06-21T14:17:34Z

@TomoYamanaka #7295 has been created.

The mainly changes is below: - Add flash_api.c - Add the definition of SPI multi I/O Bus controller that is used for flash access - Add "FLASH" as device feature - Add the macro regarding information of the incorporated Flash - Add the processing to expand code to RAM

The mainly changes is below: - Update scatter file, linker file for bootloader support - Update the file for RZ/A1 serial flash boot loader - Add "device name" and "bootloader_supported" in targets.json

I added the information of GR-LYCHEE for supporting bootloader in index.json file of arm pack manager.

I added the process for Cortex-A in mbed_application.c because this process was for only Cortex-M. Also I enabled the macro of MBED_APPLICATION_SUPPORT for Cortex-A.

I changed the information("sectors" and "memory") of GR-PEACH for supporting bootloader in index.json file of arm pack manager.

TomoYamanaka · 2018-06-22T01:57:23Z

The exporter's problem was resolved, and I rebased to resolve a conflict of "tools/arm_pack_manager/index.json".
So could you review and re-trigger CI test again?

0xc0170 · 2018-06-22T10:47:42Z

/morph build

mbed-ci · 2018-06-22T11:37:00Z

Build : SUCCESS

Build number : 2432
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6925/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-06-22T12:46:40Z

Exporter Build : SUCCESS

Build number : 2064
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6925/

mbed-ci · 2018-06-22T13:51:44Z

Test : SUCCESS

Build number : 2212
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6925/2212

mbed-ci · 2018-08-02T05:28:34Z

Exporter Build : FAILURE

Build number : 2355
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6925/

cmonr · 2018-08-02T14:33:54Z

#ghostinthemachine

0xc0170 added the needs: review label May 16, 2018

0xc0170 previously approved these changes May 18, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels May 18, 2018

0xc0170 added needs: work and removed needs: CI labels May 20, 2018

TomoYamanaka dismissed 0xc0170’s stale review via c809eda May 21, 2018 09:45

TomoYamanaka force-pushed the feature-flashiap_bootloader branch from 24c4324 to c809eda Compare May 21, 2018 09:45

cmonr previously approved these changes May 21, 2018

View reviewed changes

cmonr added needs: CI and removed needs: work labels May 21, 2018

0xc0170 added needs: work and removed needs: CI labels May 22, 2018

TomoYamanaka dismissed cmonr’s stale review via 5153617 May 23, 2018 02:44

0xc0170 added needs: CI and removed needs: work labels May 23, 2018

cmonr added needs: work release-version: 5.9.0-rc1 and removed needs: CI labels May 24, 2018

cmonr removed the release-version: 5.9.1 label Jun 14, 2018

cmonr added the needs: preceding PR label Jun 21, 2018

cmonr mentioned this pull request Jun 21, 2018

Compiling Cortex-A cores in uVision is not supported. #7295

Merged

TomoYamanaka added 6 commits June 22, 2018 10:40

Support Bootloader for GR-PEACH and GR-LYCHEE

94c13c5

The mainly changes is below: - Update scatter file, linker file for bootloader support - Update the file for RZ/A1 serial flash boot loader - Add "device name" and "bootloader_supported" in targets.json

Update arm pack manager for GR-LYCHEE

22b31e4

I added the information of GR-LYCHEE for supporting bootloader in index.json file of arm pack manager.

Add the process for Cortex-A in mbed_applicaion

5c036cb

I added the process for Cortex-A in mbed_application.c because this process was for only Cortex-M. Also I enabled the macro of MBED_APPLICATION_SUPPORT for Cortex-A.

Fix definitions of IAR exporter for GR-PEACH and GR-LYCHEE

d5f0e17

Update arm pack manager for GR-PEACH

72fd8ca

I changed the information("sectors" and "memory") of GR-PEACH for supporting bootloader in index.json file of arm pack manager.

TomoYamanaka dismissed stale reviews from theotherjimmy, 0xc0170, and cmonr via 72fd8ca June 22, 2018 01:55

TomoYamanaka force-pushed the feature-flashiap_bootloader branch from bff07fd to 72fd8ca Compare June 22, 2018 01:55

0xc0170 approved these changes Jun 22, 2018

View reviewed changes

cmonr added ready for merge release-version: 5.9.2 and removed needs: preceding PR needs: work labels Jun 22, 2018

cmonr merged commit 8e170cc into ARMmbed:master Jun 22, 2018

0xc0170 removed the ready for merge label Jun 22, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support Flash iAP and Bootloader for GR-PEACH and GR-LYCHEE #6925

Support Flash iAP and Bootloader for GR-PEACH and GR-LYCHEE #6925

TomoYamanaka commented May 16, 2018 •

edited

Loading

0xc0170 commented May 20, 2018

mbed-ci commented May 20, 2018

0xc0170 commented May 20, 2018

TomoYamanaka commented May 21, 2018

cmonr left a comment

cmonr commented May 21, 2018

mbed-ci commented May 21, 2018

mbed-ci commented May 22, 2018

mbed-ci commented May 22, 2018

0xc0170 commented May 22, 2018

TomoYamanaka commented May 23, 2018

TomoYamanaka commented May 24, 2018 •

edited

Loading

TomoYamanaka commented Jun 18, 2018

cmonr commented Jun 19, 2018

cmonr commented Jun 21, 2018

TomoYamanaka commented Jun 22, 2018

0xc0170 commented Jun 22, 2018

mbed-ci commented Jun 22, 2018

mbed-ci commented Jun 22, 2018

mbed-ci commented Jun 22, 2018

mbed-ci commented Aug 2, 2018

cmonr commented Aug 2, 2018

Support Flash iAP and Bootloader for GR-PEACH and GR-LYCHEE #6925

Support Flash iAP and Bootloader for GR-PEACH and GR-LYCHEE #6925

Conversation

TomoYamanaka commented May 16, 2018 • edited Loading

Description

Pull request type

0xc0170 commented May 20, 2018

mbed-ci commented May 20, 2018

0xc0170 commented May 20, 2018

TomoYamanaka commented May 21, 2018

cmonr left a comment

Choose a reason for hiding this comment

cmonr commented May 21, 2018

mbed-ci commented May 21, 2018

Triggering tests

mbed-ci commented May 22, 2018

mbed-ci commented May 22, 2018

0xc0170 commented May 22, 2018

TomoYamanaka commented May 23, 2018

TomoYamanaka commented May 24, 2018 • edited Loading

TomoYamanaka commented Jun 18, 2018

cmonr commented Jun 19, 2018

cmonr commented Jun 21, 2018

TomoYamanaka commented Jun 22, 2018

0xc0170 commented Jun 22, 2018

mbed-ci commented Jun 22, 2018

Triggering tests

mbed-ci commented Jun 22, 2018

mbed-ci commented Jun 22, 2018

mbed-ci commented Aug 2, 2018

cmonr commented Aug 2, 2018

TomoYamanaka commented May 16, 2018 •

edited

Loading

TomoYamanaka commented May 24, 2018 •

edited

Loading