-
Notifications
You must be signed in to change notification settings - Fork 3k
Move BlockDevice classes inside mbed namespace #7663
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0bcb34c
to
5832811
Compare
Will resolve conflict and rebase once #7660 is in. |
5832811
to
e36cd00
Compare
Rebased + preceding PR merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too 👍
/morph build |
Build : FAILUREBuild number : 2745 |
trying build after adding missing header file /morph build |
/morph build |
Build : FAILUREBuild number : 2749 |
Build failure indicates missing header file inclusion (I found at least |
3a82791
to
8f2f6f4
Compare
/morph build |
Build : SUCCESSBuild number : 2755 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2384 |
Test : SUCCESSBuild number : 2478 |
This should definitely be up for the next feature release (I would go for major if this breaks whoever includes just blockdevice and use it without
|
FatFileSystem is our implementation but it used ChanFs so was not sure if we can have it inside mbed namespace. Same is true for LittleFileSystem |
@0xc0170 @AnotherButler - Please suggest the good place to capture this change. All our examples use "mbed.h" and since class reference is directly pulled from code it will have namespace in reference. |
Both FATFileSystem and LittleFileSystem should be inside mbed namespace. IMO All classes in mbed-os should be inside the mbed namespace. I don't know of any reasons this shouldn't be true. @0xc0170 +1 For holding this until a minor release |
Move BlockDevice classes inside mbed namespace
Description
Move BlockDevice classes inside mbed namespace. Resolves: #6684
Dependent on PR: ##7660
Pull request type