Filesystem Class added to mbed namespace #7747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geky
approved these changes
Aug 9, 2018
| @@ -205,8 +206,8 @@ DRESULT disk_read(BYTE pdrv, BYTE *buff, DWORD sector, UINT count) | |||
| { | |||
There was a problem hiding this comment.
Could the disk functions still live in the mbed namespace if you declare them as extern "C"?
There was a problem hiding this comment.
If they are declared as extern "C" then they are part of the global namespace; the only one C knows.
There was a problem hiding this comment.
Though declaring them as extern "C" allows you to use anything from the mbed namespace and also notates why the functions aren't in the namespace.
It's just a minor thing to note
deepikabhavnani
force-pushed
the
fs_namespace
branch
from
38b3f22 to
3f69d1a
Compare
|
Why is the breaking change box not ticked ? |
|
FYI should probably wait for resolution of #7757 |
|
Need to wait for major version release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moving FatFs and LittleFs inside mbed namespace. More info : #7663
Please note:All disk operations implemented for ChanFs (inside FATFileSystem.cpp file) are excluded from mbed namespace. https://github.com/ARMmbed/mbed-os/blob/master/features/filesystem/fat/FATFileSystem.cpp#L140
Pull request type
Targeted to minor release