realtek rtl8195am Add MCU_target #7704

M-ichae-l · 2018-08-06T11:27:17Z

Description

1, edit "targets.json" to let "REALTEK_RTL8195AM" target inherit from "MCU_RTL8195A"

Pull request type

[X] Refactor

1, edit "targets.json" to let "REALTEK_RTL8195AM" target inherit from "MCU_RTL8195A"

0xc0170 · 2018-08-06T11:42:10Z

Isn't this also missing folder structure reorganization? To be specific, PinNames are platform specific so they should be in TARGET_RTL8195A for instance. Opposite to that, HAL implementation can be moved to MCU_RTL8195A

What I expect to see in TARGET_RTL8195A - peripheral names/pins and Pinnames plus any specific target setting.

0xc0170 · 2018-08-06T11:49:51Z

The result of this PR would be elimination of this tree https://github.com/SigmaDeltaTechnologiesInc/mbed-os/tree/0046800c092cd14fc265573a4ebb635b42bf8561/targets/TARGET_Realtek/TARGET_AMEBA (this diff is taken from #7669 )

M-ichae-l · 2018-08-07T09:48:26Z

@0xc0170

Could you be more specific about the folder structure reorganization?

For the MCU_RTL8195A, will have "core", "default_toolchain", "macros" and "supported_toolchains", "post_binary_hook", "release_versions", "overrides".
For the REALTEK_RTL8195AM, will have "supported_form_factors", "detect_code", "extra_labels", "device_has".
SDT8195B can inherits MCU_RTL8195A with its own "detect_code", "extra_labels", "device_has", "features"

0xc0170 · 2018-08-07T13:57:06Z

This basically creates only json changes but no folder tree.

If I create a new target named MY_NEW_TARGET that inherits from MCU_RTL8195A, what files would I get? Only SDK and wifi. But I would not have HAL implementation (this is related to SDK therefore my new target should have the same HAL implementation, is that correct?).

My assumption would be that this folder https://github.com/ARMmbed/mbed-os/tree/master/targets/TARGET_Realtek/TARGET_AMEBA/TARGET_RTL8195A needs to be renamed to MCU_RTL8195A, and new folder inside this one to be created named TARGET_RTL8195A (this one contains board specific configuration).

To Ilustrate the tree:

- targets/TARGET_Realtek/TARGET_AMEBA
  - TARGET_MCU_RTL8195A
    - TARGET_RTL8195A
    - TARGET_MY_NEW_TARGET

Then all I need to do for MY_NEW_TARGET would be to add board specific files (pinnames, peripheral names, board config like init different if I need one) inside TARGET_MY_NEW_TARGET and that is it !

1, edit "targets.json"

cmonr · 2018-08-08T03:10:47Z

@M-ichae-l Fyi, this still looks like it needs some work to pass Travis.

M-ichae-l · 2018-08-08T03:20:15Z

@0xc0170
Thank you!
Please refer to my branch https://github.com/M-ichae-l/mbed-os/tree/realtek-rtl8195am-Add-MCU_target-update/targets. Check if this update is OK.

0xc0170 · 2018-08-08T06:25:35Z

https://github.com/M-ichae-l/mbed-os/blob/realtek-rtl8195am-Add-MCU_target-update/targets/TARGET_Realtek/TARGET_AMEBA/TARGET_MCU_RTL8195A/TARGET_RTL8195A/i2c_api.c

HAL implementation is generic that could be moved to MCU_ folder? One thing to change there, the peripheral names : https://github.com/M-ichae-l/mbed-os/blob/realtek-rtl8195am-Add-MCU_target-update/targets/TARGET_Realtek/TARGET_AMEBA/TARGET_MCU_RTL8195A/TARGET_RTL8195A/i2c_api.c#L29 - this should be in own code file defined for TARGET_RTL8195A

The example is here https://github.com/M-ichae-l/mbed-os/blob/realtek-rtl8195am-Add-MCU_target-update/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/TARGET_MTS_GAMBIT/PeripheralPins.c for instance.

We would have then one HAL implementation for this MCU family, and multiple targets supporting it.

M-ichae-l · 2018-08-08T09:16:31Z

@0xc0170
Thank you. I have updated my branch https://github.com/M-ichae-l/mbed-os/tree/realtek-rtl8195am-Add-MCU_target-update/targets .

0xc0170 · 2018-08-08T09:38:13Z

One last thing I can think of: https://github.com/M-ichae-l/mbed-os/blob/realtek-rtl8195am-Add-MCU_target-update/targets/TARGET_Realtek/TARGET_AMEBA/TARGET_MCU_RTL8195A/serial_api.c#L30 - this pinmap is board specific. Shall it be moved to out of the implementation and inside TARGET_RTL8195A.

Look at

The example is here https://github.com/M-ichae-l/mbed-os/blob/realtek-rtl8195am-Add-MCU_target-update/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_MCU_K64F/TARGET_MTS_GAMBIT/PeripheralPins.c for instance.

M-ichae-l · 2018-08-08T10:15:32Z

Yes, There are 4 files are pinmap board specific. i2c_api.c, pwmout_api.c, serial_api.c and spi_api.c. Sould they all move to TARGET_RTL8195A ?

0xc0170 · 2018-08-08T10:24:26Z

The file serial_api.c is fine as it is - this is not board specific? The only code that it is are pins (each board can have different pinout). Therefore move those pins definitions to the TARGET_RTL8195A

TARGET_RTL8195A would have for instance PeripheralPins.c file that will contain:

const PinMap PinMap_UART_TX[] = {
    {PC_3,  RTL_PIN_PERI(UART0, 0, S0), RTL_PIN_FUNC(UART0, S0)},
    {PE_0,  RTL_PIN_PERI(UART0, 0, S1), RTL_PIN_FUNC(UART0, S1)},
    {PA_7,  RTL_PIN_PERI(UART0, 0, S2), RTL_PIN_FUNC(UART0, S2)},
    {PD_3,  RTL_PIN_PERI(UART1, 1, S0), RTL_PIN_FUNC(UART1, S0)},
    {PE_4,  RTL_PIN_PERI(UART1, 1, S1), RTL_PIN_FUNC(UART1, S1)},
    {PB_5,  RTL_PIN_PERI(UART1, 1, S2), RTL_PIN_FUNC(UART1, S2)},
    {PA_4,  RTL_PIN_PERI(UART2, 2, S0), RTL_PIN_FUNC(UART2, S0)},
    {PC_9,  RTL_PIN_PERI(UART2, 2, S1), RTL_PIN_FUNC(UART2, S1)},
    {PD_7,  RTL_PIN_PERI(UART2, 2, S2), RTL_PIN_FUNC(UART2, S2)},
    {PB_0,  RTL_PIN_PERI(LOG_UART, 3, S0), RTL_PIN_FUNC(LOG_UART, S0)},
    {NC,    NC,     0}
};

const PinMap PinMap_UART_RX[] = {
    {PC_0,  RTL_PIN_PERI(UART0, 0, S0), RTL_PIN_FUNC(UART0, S0)},
    {PE_3,  RTL_PIN_PERI(UART0, 0, S1), RTL_PIN_FUNC(UART0, S1)},
    {PA_6,  RTL_PIN_PERI(UART0, 0, S2), RTL_PIN_FUNC(UART0, S2)},
    {PD_0,  RTL_PIN_PERI(UART1, 1, S0), RTL_PIN_FUNC(UART1, S0)},
    {PE_7,  RTL_PIN_PERI(UART1, 1, S1), RTL_PIN_FUNC(UART1, S1)},
    {PB_4,  RTL_PIN_PERI(UART1, 1, S2), RTL_PIN_FUNC(UART1, S2)},
    {PA_0,  RTL_PIN_PERI(UART2, 2, S0), RTL_PIN_FUNC(UART2, S0)},
    {PC_6,  RTL_PIN_PERI(UART2, 2, S1), RTL_PIN_FUNC(UART2, S1)},
    {PD_4,  RTL_PIN_PERI(UART2, 2, S2), RTL_PIN_FUNC(UART2, S2)},
    {PB_1,  RTL_PIN_PERI(LOG_UART, 3, S0), RTL_PIN_FUNC(LOG_UART, S0)},
    {NC,    NC,     0}
};

and serial_api.c file would just pull it via header file (PeripheralPins.h that we would need to create in MCU_ folder - valid for all _api files) or use extern const PinMap PinMap_SPI_SCLK[]; at the top of the serial_api.c file.

0xc0170 · 2018-08-08T12:10:11Z

I've noticed this now that is in line what we are doing here https://github.com/ARMmbed/mbed-os-5-docs/pull/625/files#diff-1b25b067ef8a80bc82c45ca7e4809ec5R73 (docs update ongoing). There's the structure I am describing here!

M-ichae-l · 2018-08-13T03:10:01Z

@0xc0170
Thank you!
I have committed a new update please refer to,
https://github.com/M-ichae-l/mbed-os/tree/realtek-rtl8195am-Add-MCU_target-update/targets/TARGET_Realtek/TARGET_AMEBA/TARGET_MCU_RTL8195A

cmonr · 2018-08-14T01:10:39Z

@ashok-rao @bentcooke Could I ask for y'alls help here? Looking at the branch's directory structure, the port looks ok, but this is the first time I've looked at the file structure for a port and could use some help.

cmonr · 2018-08-14T01:11:14Z

@M-ichae-l Making sure, the links in your comment aren't yet pushed to this PR, correct?

M-ichae-l · 2018-08-14T02:37:43Z

@cmonr
No, I have not pushed the PR yet.

ashok-rao · 2018-08-14T09:38:53Z

@cmonr & @M-ichae-l : a minor comment regarding port_api.c, objects.h and device.h -> here ..Can these 3 be moved to the MCU level rather than the board level?

Rest all LGTM! Thanks.

ashok-rao

Overall LGTM, I've left 1 comment. Great if you could address this @M-ichae-l . Thanks!

M-ichae-l · 2018-08-17T03:34:54Z

@ashok-rao @cmonr
I have moved the three files under MCU folder. I have tested with greentea there are no issues.
Please refer to https://github.com/M-ichae-l/mbed-os/tree/realtek-rtl8195am-Add-MCU_target-update/targets/TARGET_Realtek/TARGET_AMEBA/TARGET_MCU_RTL8195A

ashok-rao

Thanks @M-ichae-l .. LGTM!

M-ichae-l · 2018-08-17T09:58:21Z

Great! The #7715 is updating the Rtl8195am lib. It is related to the structure changes here. I suggest to create PR after #7715 is merged.

bentcooke · 2018-08-17T15:31:19Z

@M-ichae-l could you please add the following entry to "MCU_RTL8195A"

"public": false,

This prevents the build system from allowing a user to build the target and is typically used for MCU definitions. Users target a board that inherits a MCU, but not the MCU by itself.

M-ichae-l · 2018-08-20T06:25:35Z

@bentcooke
I have added the "public": false,. Thank you!

cmonr · 2018-08-23T03:15:41Z

@M-ichae-l Is there a reason that this PR doesn't have the new files yet?

M-ichae-l · 2018-08-23T03:55:18Z

@cmonr
I have a branch that has all new changes
https://github.com/M-ichae-l/mbed-os/tree/realtek-rtl8195am-Add-MCU_target-update/targets/TARGET_Realtek/TARGET_AMEBA/TARGET_MCU_RTL8195A
The branch is waiting for the #7715 to be merged. After it merged, I will create a PR base on the branch above.

0xc0170 · 2018-09-03T09:05:34Z

The branch is waiting for the #7715 to be merged. After it merged, I will create a PR base on the branch above.

As that one is in progress, can this be non dependent on it? How can we progress with this MCU target ?

We have now new target addition based on this MCU

M-ichae-l · 2018-09-06T06:43:12Z

@0xc0170
I have created a PR just for lib update. #8014 After lib updated we can process for this MCU update.

0xc0170 · 2018-09-26T11:10:06Z

I have created a PR just for lib update. #8014 After lib updated we can process for this MCU update.

Integrated, rebase here or ?

0xc0170 · 2018-09-26T12:43:08Z

targets/targets.json

+        "inherits": ["MCU_RTL8195A"],
+        "detect_code": ["4600"],
+        "extra_labels": ["Realtek", "AMEBA", "RTL8195A", "RTW_EMAC"],
+        "device_has": ["ANALOGIN", "ANALOGOUT", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "SERIAL", "SPI", "TRNG", "FLASH"]


Shouldn't MCU define these ? I imagine ANALOGIN supported for that MCU. If a new derived target does not implement analogin for specific reason, it could remove it. Same for extra_labels - Realtek is specific for this target or can be applied to MCU_ one ?

"device_has" will move to the under MCU. So do "extra_labels". "extra_labels_add" will add to the specific target.

M-ichae-l · 2018-09-27T09:49:54Z

@0xc0170
I have created a new PR #8266 It includes all updates.

0xc0170 · 2018-10-01T08:52:26Z

I have created a new PR #8266 It includes all updates.

I am closing this one.

realtek rtl8195am Add MCU_target

5ddd4c9

1, edit "targets.json" to let "REALTEK_RTL8195AM" target inherit from "MCU_RTL8195A"

M-ichae-l mentioned this pull request Aug 6, 2018

Realtek: REALTEK_RTL8195AM does not have any MCU_ target defined #7690

Closed

0xc0170 added the needs: review label Aug 6, 2018

NirSonnenschein added needs: work and removed needs: review labels Aug 7, 2018

"targets.json" updates

918e603

1, edit "targets.json"

cmonr requested a review from 0xc0170 August 8, 2018 03:10

Update targets.json

be9e519

cmonr added needs: review and removed needs: work labels Aug 13, 2018

cmonr mentioned this pull request Aug 14, 2018

SDT64, 8195, 32620, 32625, 51822, 52832B added to targets #7669

Merged

cmonr requested a review from ashok-rao August 14, 2018 01:08

ashok-rao reviewed Aug 14, 2018

View reviewed changes

ashok-rao approved these changes Aug 17, 2018

View reviewed changes

0xc0170 added the needs: preceding PR label Aug 23, 2018

0xc0170 mentioned this pull request Sep 3, 2018

Add target RTL8710AF #7965

Closed

M-ichae-l mentioned this pull request Sep 6, 2018

realtek rtl8195am lib updates #8014

Merged

0xc0170 removed the needs: preceding PR label Sep 26, 2018

0xc0170 approved these changes Sep 26, 2018

View reviewed changes

0xc0170 reviewed Sep 26, 2018

View reviewed changes

0xc0170 closed this Oct 1, 2018

0xc0170 removed the needs: review label Oct 1, 2018

M-ichae-l deleted the realtek-rtl8195am-Add-MCU_target branch October 26, 2018 03:20

realtek rtl8195am Add MCU_target #7704

realtek rtl8195am Add MCU_target #7704

Uh oh!

Conversation

M-ichae-l commented Aug 6, 2018

Description

Pull request type

Uh oh!

0xc0170 commented Aug 6, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Aug 6, 2018

Uh oh!

M-ichae-l commented Aug 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Aug 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmonr commented Aug 8, 2018

Uh oh!

M-ichae-l commented Aug 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Aug 8, 2018

Uh oh!

M-ichae-l commented Aug 8, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Aug 8, 2018

Uh oh!

M-ichae-l commented Aug 8, 2018

Uh oh!

0xc0170 commented Aug 8, 2018

Uh oh!

0xc0170 commented Aug 8, 2018

Uh oh!

M-ichae-l commented Aug 13, 2018

Uh oh!

cmonr commented Aug 14, 2018

Uh oh!

cmonr commented Aug 14, 2018

Uh oh!

M-ichae-l commented Aug 14, 2018

Uh oh!

ashok-rao commented Aug 14, 2018

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

M-ichae-l commented Aug 17, 2018

Uh oh!

ashok-rao left a comment

Choose a reason for hiding this comment

Uh oh!

M-ichae-l commented Aug 17, 2018

Uh oh!

bentcooke commented Aug 17, 2018

Uh oh!

M-ichae-l commented Aug 20, 2018

Uh oh!

cmonr commented Aug 23, 2018

Uh oh!

M-ichae-l commented Aug 23, 2018

Uh oh!

0xc0170 commented Sep 3, 2018

Uh oh!

M-ichae-l commented Sep 6, 2018

Uh oh!

0xc0170 commented Sep 26, 2018

Uh oh!

0xc0170 Sep 26, 2018

Choose a reason for hiding this comment

Uh oh!

M-ichae-l Sep 27, 2018

Choose a reason for hiding this comment

Uh oh!

M-ichae-l commented Sep 27, 2018

Uh oh!

0xc0170 commented Oct 1, 2018

0xc0170 commented Aug 6, 2018 •

edited

Loading

M-ichae-l commented Aug 7, 2018 •

edited

Loading

0xc0170 commented Aug 7, 2018 •

edited

Loading

M-ichae-l commented Aug 8, 2018 •

edited

Loading

M-ichae-l commented Aug 8, 2018 •

edited

Loading