Platform: fix missing namespace for SharedPtr #8329

paul-szczepanek-arm · 2018-10-04T15:15:02Z

Description

Add missing mbed namespace to class. We avoid making a breaking change with the "using".

Pull request type

[ ] Fix
[x] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

deepikabhavnani · 2018-10-04T15:58:15Z

Please see #7760 and #6684. It will be good to add all namespace related fixes at one place.

0xc0170 · 2018-10-11T17:35:17Z

Please see #7760 and #6684. It will be good to add all namespace related fixes at one place.

@deepikabhavnani should this be cherry pick there or ?

deepikabhavnani · 2018-10-11T17:52:07Z

should this be cherry pick there or ?

Yes cherry pick will be good option, but will have to wait for header file fixes first

0xc0170 · 2018-10-11T17:54:26Z

Yes cherry pick will be good option, but will have to wait for header file fixes first

What is the preceding PR from the earlier referenced PR?

deepikabhavnani · 2018-10-11T17:58:46Z

PR#7760 is dependent on #7864 #8002 #8008 for now. Few more can come in later.

In order to have namespace free mbed-os, we will have to remove "mbed.h" and "using" from all header files first. Pending in "features" folder - BLE/Cellular and all Networking

cmonr · 2018-10-25T15:51:12Z

This is clear to proceed!

deepikabhavnani · 2018-10-25T15:58:43Z

platform/SharedPtr.h

@@ -285,4 +287,8 @@ bool operator!= (U lhs, const SharedPtr<T> &rhs)
    return ((T *) lhs != rhs.get());
 }

+} /* namespace mbed */
+
+using mbed::SharedPtr;


Along with addition of namespace and backward compatibility, we need to make sure we do not corrupt the global namespace hence a small change needed:

using should be under #ifndef MBED_NO_GLOBAL_USING_DIRECTIVE macro.
https://github.com/ARMmbed/mbed-os/pull/7760/files#diff-3716425795ebc1692d5a64771fa4f35eR169

paul-szczepanek-arm · 2018-10-26T07:43:12Z

using directive is now wrapped in the macro, can you sign off the reivew please @deepikabhavnani

0xc0170

Backward compatible

0xc0170 · 2018-10-30T12:01:19Z

/morph build

mbed-ci · 2018-10-30T12:53:37Z

Build : SUCCESS

Build number : 3504
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8329/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-30T14:38:12Z

Test : FAILURE

Build number : 3290
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8329/3290

mbed-ci · 2018-10-30T14:39:41Z

Exporter Build : FAILURE

Build number : 3121
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8329/

cmonr · 2018-10-30T14:42:33Z

IAR network license issues.
/morph mbed2-build

java.lang.NoClassDefFoundError: Could not initialize class hudson.slaves.SlaveComputer
Export CI had some issues, as well as IAR network issues.
/morph export-build

Aaaand finally, I don't think the lone test failue was due to the PR...
/morph test

0xc0170 · 2018-10-30T14:47:34Z

NRF52_DK-ARM.tests-mbed_hal-rtc_time_conv.test make time and local time - RTC leap years partial support

This looks like it's on master and appears seldomly these days.

@mprse Can you please review NRF52_DK-ARM.tests-mbed_hal-rtc_time_conv.test make time and local time - RTC leap years partial support failure? I've seen it today already at least in another PR

mbed-ci · 2018-10-30T20:10:21Z

Exporter Build : ABORTED

Build number : 3123
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8329/

0xc0170 · 2018-10-31T11:16:49Z

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-31T15:39:47Z

Exporter Build : SUCCESS

Build number : 3132
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8329/

mbed-ci · 2018-10-31T16:49:39Z

Test : SUCCESS

Build number : 3299
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8329/3299

paul-szczepanek-arm added 2 commits October 4, 2018 15:51

fix missing namespace mbed

3a408eb

make it backwards compatible

05a4337

paul-szczepanek-arm requested review from donatieng and pan- October 4, 2018 15:19

0xc0170 requested a review from a team October 4, 2018 15:27

0xc0170 added the needs: review label Oct 4, 2018

0xc0170 added the needs: preceding PR label Oct 11, 2018

deepikabhavnani mentioned this pull request Oct 12, 2018

Give an option to remove 'using namespace' #7760

Merged

cmonr removed the needs: preceding PR label Oct 25, 2018

deepikabhavnani reviewed Oct 25, 2018

View reviewed changes

protect using with macro

e4f3768

deepikabhavnani approved these changes Oct 26, 2018

View reviewed changes

0xc0170 approved these changes Oct 29, 2018

View reviewed changes

0xc0170 requested a review from SenRamakri October 29, 2018 12:17

pan- approved these changes Oct 30, 2018

View reviewed changes

donatieng approved these changes Oct 31, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Oct 31, 2018

cmonr added ready for merge release-version: 5.11.0-rc1 and removed needs: CI labels Oct 31, 2018

cmonr merged commit b35799d into ARMmbed:master Oct 31, 2018

cmonr removed the ready for merge label Oct 31, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Platform: fix missing namespace for SharedPtr #8329

Platform: fix missing namespace for SharedPtr #8329

paul-szczepanek-arm commented Oct 4, 2018

deepikabhavnani commented Oct 4, 2018 •

edited

Loading

0xc0170 commented Oct 11, 2018

deepikabhavnani commented Oct 11, 2018 •

edited

Loading

0xc0170 commented Oct 11, 2018

deepikabhavnani commented Oct 11, 2018

cmonr commented Oct 25, 2018

deepikabhavnani Oct 25, 2018 •

edited

Loading

paul-szczepanek-arm commented Oct 26, 2018 •

edited

Loading

0xc0170 left a comment

0xc0170 commented Oct 30, 2018

mbed-ci commented Oct 30, 2018

mbed-ci commented Oct 30, 2018

mbed-ci commented Oct 30, 2018

cmonr commented Oct 30, 2018

0xc0170 commented Oct 30, 2018

mbed-ci commented Oct 30, 2018

0xc0170 commented Oct 31, 2018

mbed-ci commented Oct 31, 2018

mbed-ci commented Oct 31, 2018

Platform: fix missing namespace for SharedPtr #8329

Platform: fix missing namespace for SharedPtr #8329

Conversation

paul-szczepanek-arm commented Oct 4, 2018

Description

Pull request type

deepikabhavnani commented Oct 4, 2018 • edited Loading

0xc0170 commented Oct 11, 2018

deepikabhavnani commented Oct 11, 2018 • edited Loading

0xc0170 commented Oct 11, 2018

deepikabhavnani commented Oct 11, 2018

cmonr commented Oct 25, 2018

deepikabhavnani Oct 25, 2018 • edited Loading

Choose a reason for hiding this comment

paul-szczepanek-arm commented Oct 26, 2018 • edited Loading

0xc0170 left a comment

Choose a reason for hiding this comment

0xc0170 commented Oct 30, 2018

mbed-ci commented Oct 30, 2018

Build : SUCCESS

Triggering tests

mbed-ci commented Oct 30, 2018

Test : FAILURE

mbed-ci commented Oct 30, 2018

Exporter Build : FAILURE

cmonr commented Oct 30, 2018

0xc0170 commented Oct 30, 2018

mbed-ci commented Oct 30, 2018

Exporter Build : ABORTED

0xc0170 commented Oct 31, 2018

mbed-ci commented Oct 31, 2018

Exporter Build : SUCCESS

mbed-ci commented Oct 31, 2018

Test : SUCCESS

deepikabhavnani commented Oct 4, 2018 •

edited

Loading

deepikabhavnani commented Oct 11, 2018 •

edited

Loading

deepikabhavnani Oct 25, 2018 •

edited

Loading

paul-szczepanek-arm commented Oct 26, 2018 •

edited

Loading