Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: general_block_device fix to always erase prior the first program #9377

Merged
merged 1 commit into from
Jan 18, 2019
Merged

test: general_block_device fix to always erase prior the first program #9377

merged 1 commit into from
Jan 18, 2019

Conversation

offirko
Copy link
Contributor

@offirko offirko commented Jan 15, 2019 •
edited
Loading

Description

general_block_device test fixed to always erase prior to first program.

Fix: K64F, K82F: failing storage tests when SD component is not available
Resolves #9235
Internal Jira reference: https://jira.arm.com/browse/MBOCUSTRIA-380

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@offirko offirko mentioned this pull request Jan 15, 2019
Closed
@offirko
Copy link
Contributor Author

offirko commented Jan 15, 2019

@ARMmbed/mbed-os-maintainers
@ARMmbed/mbed-os-storage
Please review

@0xc0170 0xc0170 changed the title general_block_device test fixed to always erase prior to first program test: general_block_device fix to always erase prior the first program Jan 15, 2019
@0xc0170 0xc0170 requested a review from a team January 15, 2019 11:56
yossi2le
yossi2le approved these changes Jan 15, 2019
View reviewed changes
Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 18, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit cee814d into ARMmbed:master Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@yossi2le yossi2le yossi2le approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

K64F, K82F: failing storage tests when SD component is not available
5 participants
@offirko @0xc0170 @mbed-ci @yossi2le @cmonr