Adding NUCLEO_WB55RG support #9814

LMESTM · 2019-02-22T14:58:10Z

Description

Here is the first Pull request to enable STM32WB55 support.
https://www.st.com/en/microcontrollers-microprocessors/stm32wb55rg.html

This port includes BLE support with CORDIO stack.

Pull request type

[ ] Fix
[ ] Refactor
[X ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@jeromecoutant @pan- @screamerbg @avilei

Release Notes

Tests are ongoing but feedback and review are welcome already.

ciarmcom · 2019-02-22T16:00:39Z

@LMESTM, thank you for your changes.
@screamerbg @pan- @ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2019-02-22T16:09:10Z

We are missing tests logs shared, please add them.

LMESTM · 2019-02-25T08:37:02Z

First test report - CI test shield tests ALL OK.
mbed2 and mbed-os tests still ongoing (there is an issue for ARM /µARM with mbed2 that I will fix)

target	platform_name	test suite	result	elapsed_time (sec)	copy_method
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-api-analogin	OK	17.19	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-api-businout	OK	32.59	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-api-digitalio	OK	17.69	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-api-i2c	OK	18.92	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-api-interruptin	OK	17.63	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-api-pwm_fall	OK	28.95	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-api-pwm_rise	OK	28.92	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-api-pwm_rise_fall	OK	181.58	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-api-spi	OK	18.53	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-assumptions-analogin	OK	20.15	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-assumptions-digitalio	OK	18.36	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-assumptions-i2c	OK	16.07	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-assumptions-pwm	OK	16.54	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-assumptions-pwmout	OK	15.93	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-assumptions-spi	OK	16.5	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-concurrent-comms	OK	18.3	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-concurrent-gpio	OK	20.06	default
NUCLEO_WB55RG-ARM	NUCLEO_WB55RG	tests-concurrent-mixed	OK	19.25	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-api-analogin	OK	17.6	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-api-businout	OK	32.95	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-api-digitalio	OK	18.14	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-api-i2c	OK	19.16	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-api-interruptin	OK	18.06	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-api-pwm_fall	OK	29.36	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-api-pwm_rise	OK	29.41	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-api-pwm_rise_fall	OK	181.88	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-api-spi	OK	19.33	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-assumptions-analogin	OK	20.3	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-assumptions-digitalio	OK	19.06	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-assumptions-i2c	OK	16.54	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-assumptions-pwm	OK	17.08	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-assumptions-pwmout	OK	16.47	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-assumptions-spi	OK	17.04	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-concurrent-comms	OK	19.0	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-concurrent-gpio	OK	20.37	default
NUCLEO_WB55RG-GCC_ARM	NUCLEO_WB55RG	tests-concurrent-mixed	OK	19.89	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-api-analogin	OK	17.02	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-api-businout	OK	33.66	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-api-digitalio	OK	17.63	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-api-i2c	OK	18.6	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-api-interruptin	OK	17.35	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-api-pwm_fall	OK	29.0	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-api-pwm_rise	OK	28.69	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-api-pwm_rise_fall	OK	181.29	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-api-spi	OK	18.44	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-assumptions-analogin	OK	19.92	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-assumptions-digitalio	OK	18.41	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-assumptions-i2c	OK	15.91	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-assumptions-pwm	OK	16.46	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-assumptions-pwmout	OK	16.07	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-assumptions-spi	OK	16.39	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-concurrent-comms	OK	18.0	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-concurrent-gpio	OK	19.92	default
NUCLEO_WB55RG-IAR	NUCLEO_WB55RG	tests-concurrent-mixed	OK	18.86	default

features/FEATURE_BLE/targets/TARGET_STM/TARGET_NUCLEO_WB55RG/hw.h

LMESTM · 2019-02-25T10:27:19Z

@0xc0170 Hi Martin, I'm looking for some guidance about my issue with ARM toolchain.

In STM32WB55RG, there is a section in shared memory that is used to communicate with the BLE sub-system.

  ; SRAM2 - Shared memory
  RW_IRAM2a 0x20030000 0x00002800  {  ; RW data
   *(MAPPING_TABLE, +First)
   *(MB_MEM1)
  }

This section is actually being used when FEATURE_BLE is active. the problem with ARM is that I get an error when compiling for MBED2 because the BLE feature is not compiled. I'd like to introduce a condition which allows to distinguish between OS2/OS5 or between BLE/not BLE in the linker script, but I could not find my way so far.

I tried using

#if defined(FEATURE_BLE)
   *(MAPPING_TABLE, +First)
#endif

but it won't be defined in mbed-os case either in the context of the linker script.

Any idea how I could / should implement this ?

EDIT: SOLVED with Martin support: no need to use the +First attribute as the alphabetical order will ensure that MAPPING_TABLE is placed before MB_MEM1 : tested OK and branch updated.
*(MAPPING_TABLE, +First)

0xc0170 · 2019-02-25T10:44:28Z

This section is actually being used when FEATURE_BLE is active. the problem with ARM is that I get an error when compiling for MBED2

What is the error ? Why does it fail?

LMESTM · 2019-02-25T12:16:06Z

This section is actually being used when FEATURE_BLE is active. the problem with ARM is that I get an error when compiling for MBED2

What is the error ? Why does it fail?

In mbed2, it will report:

    [ERROR] "C:/Data/Workspace/mbed/BUILD/test/NUCLEO_WB55RG/ARM/MBED_2/
    .link_script.sct", line 65 (column 6): Error: L6236E:
    No section matches selector - no section to be FIRST/LAST.

Because without BLE feature, there is no content fitting into the MAPPING_TABLE section, so this is empty and this seems not supported for a section with +FIRST attribute.

LMESTM · 2019-02-25T15:16:43Z

MBED2 test results for IAR and GCC_ARM - ARM (and µARM) FAILs for now because of scatter file issue, as being discussed ...

Test summary:

Result	Target	Toolchain	Test ID	Test Description	Elapsed Time (sec)	Timeout (sec)	Loops

| OK | NUCLEO_WB55RG | GCC_ARM | DTCT_1 | Simple detect test | 0.48 | 10 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | EXAMPLE_1 | /dev/null | 3.45 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_10 | Hello World | 0.37 | 5 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_11 | Ticker Int | 11.4 | 15 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_12 | C++ | 1.36 | 10 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_16 | RTC | 4.59 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_2 | stdio | 0.76 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_23 | Ticker Int us | 11.39 | 15 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_24 | Timeout Int us | 12.29 | 15 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_25 | Time us | 11.43 | 15 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_26 | Integer constant division | 1.37 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_34 | Ticker Two callbacks | 11.43 | 15 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_37 | Serial NC RX | 7.03 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_38 | Serial NC TX | 6.02 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_A1 | Basic | 1.4 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_A21 | Call function before main (mbed_main) | 1.45 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_A9 | Serial Echo at 115200 | 1.26 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | GCC_ARM | MBED_BUSOUT | BusOut | 2.31 | 30 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | DTCT_1 | Simple detect test | 0.47 | 10 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | EXAMPLE_1 | /dev/null | 3.48 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_10 | Hello World | 0.36 | 5 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_11 | Ticker Int | 11.42 | 15 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_12 | C++ | 1.4 | 10 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_16 | RTC | 4.54 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_2 | stdio | 0.76 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_23 | Ticker Int us | 11.39 | 15 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_24 | Timeout Int us | 12.15 | 15 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_25 | Time us | 11.51 | 15 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_26 | Integer constant division | 1.4 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_34 | Ticker Two callbacks | 11.39 | 15 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_37 | Serial NC RX | 7.05 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_38 | Serial NC TX | 5.99 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_A1 | Basic | 1.39 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_A21 | Call function before main (mbed_main) | 1.44 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_A9 | Serial Echo at 115200 | 1.23 | 20 | 1/1 |
| OK | NUCLEO_WB55RG | IAR | MBED_BUSOUT | BusOut | 2.29 | 30 | 1/1 |

LMESTM · 2019-02-26T08:00:59Z

And the mbed-os 5 results.

The BLE timeout cases in ARM TC are related to the mbed2 / linker script problem I've raised : I have tried to make the Shared Memory section conditional and I haven't succeeded, so the shared memory section is missing in this ARM build.

Updated with last commit:

+-------------------+---------------+-----------------------------------------------------------------------+--------+--------------------+-------------+
| target            | platform_name | test suite                                                            | result | elapsed_time (sec) | copy_method |
+-------------------+---------------+-----------------------------------------------------------------------+--------+--------------------+-------------+
| NUCLEO_WB55RG-ARM | NUCLEO_WB55RG | features-feature_ble-targets-target_cordio-tests-cordio_hci-driver    | OK     | 17.17              | default     |
| NUCLEO_WB55RG-ARM | NUCLEO_WB55RG | features-feature_ble-targets-target_cordio-tests-cordio_hci-transport | OK     | 28.79              | default     |
+-------------------+---------------+-----------------------------------------------------------------------+--------+--------------------+-------------+

TOTAL:
mbedgt: test suite results: 321 OK

targets/TARGET_STM/TARGET_STM32WB/TARGET_STM32WB55xG/device/TOOLCHAIN_ARM_MICRO/stm32wb55xx.sct

0xc0170 · 2019-02-27T13:27:42Z

Note, #9571 - might have implications for new targets. Please review (there's design document, and targets updated, if any questions, let us know). In any case, please reply to this comment if this change is already done or when completed.

LMESTM · 2019-02-27T16:49:17Z

One comment about MBED2 testing, I have rebased on top of master and there seems to be issues with building MBED2 with uARM toolchain.
I get
Error: L6218E: Undefined symbol $Super$$__rt_lib_init (referred from mbed_retarget.o).
Error: L6218E: Undefined symbol __use_two_region_memory (referred from mbed_retarget.o).
Not only for STM32WB but also for other targets like L496.
Is this a know issue ?

cmonr · 2019-02-27T19:26:34Z

@ARMmbed/mbed-os-core ^^^

cmonr · 2019-02-27T19:34:42Z

@LMESTM Would it be worth looking into the Python issues while the team gets a chance to look this over?

deepikabhavnani · 2019-02-27T22:04:17Z

@LMESTM - uARM issue should be resolved with #9766. Please let me know if you still see failures after applying changes form 9766

LMESTM · 2019-02-28T08:14:54Z

@deepikabhavnani Thanks - I'm good as this is clearly already known and addressed :-)

@cmonr About python issues, I guess you're referring to travis-ci/tools-py2.7errors ? It says the device name is not known. Where does the list of known device come from ?

0xc0170 · 2019-02-28T08:19:55Z

@LMESTM device_name error comes from cmsis pack manager - the device is not known - is it valid ?

From the docs: We use the tool ArmPackManager to parse CMSIS Packs for target information. index.json stores the parsed information from the PDSC (Pack Description) See https://os.mbed.com/docs/mbed-os/v5.11/reference/adding-and-configuring-targets.html

LMESTM · 2019-02-28T08:44:01Z

@LMESTM device_name error comes from cmsis pack manager - the device is not known - is it valid ?

I think it is valid, but this target has been officially published only last week. I don't know how much time it'll take to get into the CMSIS pack and then from CMSIS pack to mbed-os ?

When doing so, do not disbale GPIO clocks as they may be used by other drivers ! As a result, debug will be disabled by default, but can be enabled by either modifying code or selecting MBED debug profile.

Typically the RTC clock is configured by RTC driver itself. RNG on the other hand is shared with M0+ core and it is expected that M4 turns it on at boot time.

Internal channels use is enabling ADC "internal path" which needs to be disabled after measurement. Same applied here for WB family as was done for others in ARMmbed#10143.

LMESTM · 2019-03-29T15:24:24Z

I was planning to wait for merge, then send separate PRs for supporting deep sleep mode and add few other side fixes, but considering the situation, I've rebased on top of mbed/mater an added few more commits to this PR. This update includes:

Adding HW semaphore for Flash and TRNG
Update linker script for GCC to align with recent changes on master
Fix clock settings to support Deep sleep entry / exit when tickless mode is active

pan-

Validated on the BLE side. Thanks @paul-szczepanek-arm

0xc0170 · 2019-04-03T09:55:49Z

CI started

0xc0170 · 2019-04-03T09:56:03Z

@ashok-rao Please review

LMESTM · 2019-04-03T10:01:47Z

Special thanks to @paul-szczepanek-arm !

mbed-ci · 2019-04-03T12:25:32Z

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 5
Build artifacts

LMESTM · 2019-04-04T12:14:01Z

@0xc0170 Is there anything blocking the merge now ?

0xc0170 · 2019-04-04T13:01:12Z

I would like to have @ashok-rao review, let me check with him again today and make this ready asap.

ashok-rao

LGTM from a new target perspective. Thanks @LMESTM

LMESTM · 2019-04-04T13:28:46Z

LGTM from a new target perspective. Thanks @LMESTM
@ashok-rao Thanks for quick feedback

LMESTM changed the title ~~Dev nucleo wb55 rg~~ Adding NUCLEO_WB55RG support Feb 22, 2019

ciarmcom requested review from pan-, screamerbg and a team February 22, 2019 16:00

ciarmcom added the needs: review label Feb 22, 2019

0xc0170 added the scope: new-target label Feb 22, 2019

0xc0170 requested changes Feb 25, 2019

View reviewed changes

features/FEATURE_BLE/targets/TARGET_STM/TARGET_NUCLEO_WB55RG/hw.h Outdated Show resolved Hide resolved

cmonr added needs: work and removed needs: review labels Feb 25, 2019

0xc0170 reviewed Feb 26, 2019

View reviewed changes

targets/TARGET_STM/TARGET_STM32WB/TARGET_STM32WB55xG/device/TOOLCHAIN_ARM_MICRO/stm32wb55xx.sct Outdated Show resolved Hide resolved

LMESTM force-pushed the dev_NUCLEO_WB55RG branch 2 times, most recently from 2d249d0 to d91cc65 Compare February 27, 2019 09:40

LMESTM force-pushed the dev_NUCLEO_WB55RG branch from d91cc65 to 2cf0719 Compare February 27, 2019 16:47

LMESTM added 3 commits March 29, 2019 16:21

STM32WB: disable debug lines when not needed

a744343

When doing so, do not disbale GPIO clocks as they may be used by other drivers ! As a result, debug will be disabled by default, but can be enabled by either modifying code or selecting MBED debug profile.

STM32WB: Only configure default peripherals in SetSysClock

c627798

Typically the RTC clock is configured by RTC driver itself. RNG on the other hand is shared with M0+ core and it is expected that M4 turns it on at boot time.

STM32WB: ADC INTERNAL CHANNEL reset after read

b0f4815

Internal channels use is enabling ADC "internal path" which needs to be disabled after measurement. Same applied here for WB family as was done for others in ARMmbed#10143.

cmonr requested review from paul-szczepanek-arm, screamerbg and 0xc0170 and removed request for paul-szczepanek-arm and screamerbg March 29, 2019 17:06

paul-szczepanek-arm approved these changes Apr 3, 2019

View reviewed changes

pan- approved these changes Apr 3, 2019

View reviewed changes

0xc0170 approved these changes Apr 3, 2019

View reviewed changes

0xc0170 added needs: CI and removed needs: work labels Apr 3, 2019

0xc0170 added needs: review and removed needs: CI labels Apr 3, 2019

ashok-rao approved these changes Apr 4, 2019

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Apr 4, 2019

0xc0170 merged commit c2ebb79 into ARMmbed:master Apr 4, 2019

0xc0170 removed the ready for merge label Apr 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding NUCLEO_WB55RG support #9814

Adding NUCLEO_WB55RG support #9814

LMESTM commented Feb 22, 2019

ciarmcom commented Feb 22, 2019

0xc0170 commented Feb 22, 2019

LMESTM commented Feb 25, 2019

LMESTM commented Feb 25, 2019 •

edited

Loading

0xc0170 commented Feb 25, 2019

LMESTM commented Feb 25, 2019

LMESTM commented Feb 25, 2019

LMESTM commented Feb 26, 2019 •

edited

Loading

0xc0170 commented Feb 27, 2019 •

edited

Loading

LMESTM commented Feb 27, 2019 •

edited

Loading

cmonr commented Feb 27, 2019

cmonr commented Feb 27, 2019

deepikabhavnani commented Feb 27, 2019

LMESTM commented Feb 28, 2019

0xc0170 commented Feb 28, 2019

LMESTM commented Feb 28, 2019

LMESTM commented Mar 29, 2019

pan- left a comment

0xc0170 commented Apr 3, 2019

0xc0170 commented Apr 3, 2019

LMESTM commented Apr 3, 2019

mbed-ci commented Apr 3, 2019

LMESTM commented Apr 4, 2019

0xc0170 commented Apr 4, 2019

ashok-rao left a comment

LMESTM commented Apr 4, 2019

Adding NUCLEO_WB55RG support #9814

Adding NUCLEO_WB55RG support #9814

Conversation

LMESTM commented Feb 22, 2019

Description

Pull request type

Reviewers

Release Notes

ciarmcom commented Feb 22, 2019

0xc0170 commented Feb 22, 2019

LMESTM commented Feb 25, 2019

LMESTM commented Feb 25, 2019 • edited Loading

0xc0170 commented Feb 25, 2019

LMESTM commented Feb 25, 2019

LMESTM commented Feb 25, 2019

LMESTM commented Feb 26, 2019 • edited Loading

0xc0170 commented Feb 27, 2019 • edited Loading

LMESTM commented Feb 27, 2019 • edited Loading

cmonr commented Feb 27, 2019

cmonr commented Feb 27, 2019

deepikabhavnani commented Feb 27, 2019

LMESTM commented Feb 28, 2019

0xc0170 commented Feb 28, 2019

LMESTM commented Feb 28, 2019

LMESTM commented Mar 29, 2019

pan- left a comment

Choose a reason for hiding this comment

0xc0170 commented Apr 3, 2019

0xc0170 commented Apr 3, 2019

LMESTM commented Apr 3, 2019

mbed-ci commented Apr 3, 2019

Test run: SUCCESS

LMESTM commented Apr 4, 2019

0xc0170 commented Apr 4, 2019

ashok-rao left a comment

Choose a reason for hiding this comment

LMESTM commented Apr 4, 2019

LMESTM commented Feb 25, 2019 •

edited

Loading

LMESTM commented Feb 26, 2019 •

edited

Loading

0xc0170 commented Feb 27, 2019 •

edited

Loading

LMESTM commented Feb 27, 2019 •

edited

Loading