Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbed_rom_size values from mbed_app.json are ignored #283

Closed
jeromecoutant opened this issue May 21, 2021 · 0 comments · Fixed by #284
Closed

mbed_rom_size values from mbed_app.json are ignored #283

jeromecoutant opened this issue May 21, 2021 · 0 comments · Fixed by #284
Assignees
@rwalton-arm
Labels
bug Something isn't working

Comments

@jeromecoutant
Copy link

Describe the bug

#270 has implemented mbed_rom_size support in targets.json file,
But it seems that if values is overwritten in the local mbed_app.json file, value is ignored

@wernerlewis

To Reproduce
Steps to reproduce the behavior:

  • choose a target with "mbed_rom_size" defined
  • change the value in mbed_app.json: "target.mbed_rom_size"
  • see in mbed_config.cmake
@jeromecoutant jeromecoutant added the bug Something isn't working label May 21, 2021
@rwalton-arm rwalton-arm self-assigned this May 24, 2021
rwalton-arm added a commit to rwalton-arm/mbed-tools that referenced this issue May 24, 2021
@rwalton-arm
config: Add memory region parameters to mbed_config.cmake
8f1df1b 
Add memory region defines to mbed_config.tmpl so they end up in
mbed_config.cmake.

Fixes ARMmbed#283
@rwalton-arm rwalton-arm mentioned this issue May 25, 2021
Merged
3 tasks
Patater pushed a commit that referenced this issue May 26, 2021
@rwalton-arm @Patater
config: Add memory region parameters to mbed_config.cmake
ff2da40 
Add memory region defines to mbed_config.tmpl so they end up in
mbed_config.cmake.

Fixes #283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwalton-arm rwalton-arm

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue with memory region overrides rwalton-arm/mbed-tools
2 participants
@jeromecoutant @rwalton-arm