Fix issue with memory region overrides #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't need special handling for mbed_rom/ram_start or mbed_rom/ram_size as they are already collected (if present in targets.json). The reason mbed_app.json overrides were "ignored" is because the overrides were applied to the already collected string parameters and weren't applied to the extracted `Memory` objects we expose in the template.
Add memory region defines to mbed_config.tmpl so they end up in mbed_config.cmake. Fixes ARMmbed#283
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
- Coverage 97.12% 97.07% -0.05%
==========================================
Files 92 92
Lines 2813 2773 -40
==========================================
- Hits 2732 2692 -40
Misses 81 81
|
|
Travis passed, but failed to report back to GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MBED_ROM/RAM_START/SIZE overrides were not added to
mbed_config.cmake.
The reason mbed_app.json overrides were "ignored" is
because the overrides were applied to the already collected string
parameters and weren't applied to the extracted
Memoryobjects weexpose in the template.
We shouldn't need special handling for mbed_rom/ram_start or
mbed_rom/ram_size as they are already collected (if present in
targets.json). So remove the special handling for memory regions.
A side effect of this approach is that we remove some of the validation
checks for START and SIZE both being defined. If we feel this is a
necessary check we can add it back into the
Configobject.Fixes #283
Test Coverage