Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi size grid #15988

Merged
merged 1 commit into from
Jun 10, 2024
Merged

multi size grid #15988

merged 1 commit into from
Jun 10, 2024

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Jun 10, 2024

Description

fix issue with stiching grid with different size images
currently the base grid size of the stitched grid is based on the first image in the input images
if any dimension of a subsequent images are greater than the first image this will result in subsequent images being cut off

this can happen when using xyz grid with axis Size

  • improved the grid stitching amd annotation of XYZ grid so that it will handle multiple images size
  • the largest dimension of all the input images will be used as the base grid size
  • if the sub image size is different from the base grid size, the then it will be offset to the center of the base grid
  • backgroud of the grid respect the setting shared.opts.grid_background_color

with more work it should be possible to remove the gaps between images but this will require more work on The annotation function so that it accepts a list of dimension for it to space out the labels correctly
note: note that removing the gaps would also cause the grid to be misaligned, which some people may find annoying

some people might prefer the image to not be centered, but I do not implement this as an option
this could be done by just not calculating the offset
https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/15988/files#diff-7035c0b11c034183a4d5570fccaf498d0e1ceea6f1a70efffab2bf963703739aR62-R63

Screenshots/videos:

Current (Issue)
20240610-194523-723792 1 9588

the bottom of the right grid is cutoff

PR

20240610-204611-448485 1 1fd1
20240610-204541-857462 1 ce88
20240610-204516-930990 1 dfd9

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit 123582b into dev Jun 10, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the multi-size-grid branch June 10, 2024 13:44
@lawchingman lawchingman mentioned this pull request Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants