-
Notifications
You must be signed in to change notification settings - Fork 27k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sampler scheduler autocorrection warning #16054
Fix sampler scheduler autocorrection warning #16054
Conversation
4e8fb4b
to
82ca10f
Compare
82ca10f
to
0f40c4b
Compare
Yeah, it makes it seem like it’s switching to a different scheduler. |
@DotPoker2 send me a screenshort of your UI before you click generate from what I can see
it is is working as intended try disabling all extensions for now |
|
did you try disabling all extensions? |
i'll try it, but i doubt that's the solution, will update you if it works or not. |
btw https://github.com/KohakuBlueleaf/LyCORIS.git is not an extension |
right |
so, if i don't get the warning, can i slowly add back my extensions one at a time to see if one of them is causing the error? |
yes |
so far, CivitAi extension, nor Regional Prompter, aren't the culprits causing the error, i'll reply more after i test the other's. |
Adetailer itself isn't the cause, i'm wondering if it's a model i use in Adetailer. |
since this is the case report this is to adetailer, somewhere in their code they they forgot to specify scheduler type |
it seems to be the Adetailer yolo models that are causing the error for the sampler scheduler error. |
yes, case closed |
ugh, so how do you plan to get this fixed? does this now go to a1111 and Bing-su to resolve this? |
I don't plan on anything, and there is nothing I can do even if I want to if you wanted to be fixed now, you need to switch to adetailer dev branch
or you can wait until Bing-su pushes the fix to adetailer main branch |
|
no you're not |
i've used adetailer for three months, i think i know what i'm doing. |
using the software and the development the software is completely different thing when you say
and then share a screenshot of github if you want to switch branch you need to have a basic understanding of how to use git |
I updated the branch of Adetailer to dev, no issues with anything, the error is gone, sorry @w-e-w for the words. |
Description
fix unnecessary sampler scheduler autocorrection warning
from Discussions post
user has reported erroneous scheduler autocorrection warning
essentially under certain circumstances such as
sampler
DPM++ 2M
+ scheduleKarras
they will see the sampler scheduler autocorrection warningthis is because of default schedule for
DPM++ 2M
isKarras
, and so the retruned schedule ofget_sampler_and_scheduler()
will beAutomatic
Karras
this triggers a false warning because
Automatic
!=Karras
functionality wise It's harmless but it does confuse people
fix:
add new a arg
convert_automatic: bool
toget_sampler_and_scheduler()
that disablesrevert back to Automatic if it's the default scheduler for the selected sampler
behavioradditional unrelated change that I decide to throw in
Checklist: