Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sequence Diagrams and fix JUnit test #207

Merged
merged 1 commit into from
Nov 7, 2021

Conversation

kelvneo
Copy link

@kelvneo kelvneo commented Nov 7, 2021

No description provided.

@kelvneo kelvneo added this to the v2.1 milestone Nov 7, 2021
@kelvneo kelvneo self-assigned this Nov 7, 2021
@codecov
Copy link

codecov bot commented Nov 7, 2021

Codecov Report

Merging #207 (e30137d) into master (19b7d8a) will increase coverage by 0.27%.
The diff coverage is 80.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #207      +/-   ##
============================================
+ Coverage     88.09%   88.37%   +0.27%     
- Complexity      531      535       +4     
============================================
  Files            65       65              
  Lines          1521     1531      +10     
  Branches        143      145       +2     
============================================
+ Hits           1340     1353      +13     
+ Misses           88       87       -1     
+ Partials         93       91       -2     
Impacted Files Coverage Δ
...in/java/terminus/activerecall/GameEnvironment.java 94.82% <0.00%> (ø)
src/main/java/terminus/Terminus.java 74.19% <100.00%> (-0.54%) ⬇️
src/main/java/terminus/storage/StorageManager.java 90.00% <0.00%> (-2.99%) ⬇️
src/main/java/terminus/common/Messages.java 66.66% <0.00%> (ø)
src/main/java/terminus/storage/PdfStorage.java 94.59% <0.00%> (ø)
src/main/java/terminus/storage/FilterManager.java 89.61% <0.00%> (+1.73%) ⬆️
src/main/java/terminus/storage/Storage.java 75.55% <0.00%> (+4.72%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19b7d8a...e30137d. Read the comment docs.

Copy link
Collaborator

@3m0W33D 3m0W33D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kelvneo kelvneo merged commit cc8d5bb into AY2122S1-CS2113T-T10-2:master Nov 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants