Update Sequence Diagrams and fix JUnit test

docs/uml/ActiveRecallSequenceDiagram.puml

@@ -34,8 +34,10 @@ activate GameEnvironment
     ref over GameEnvironment, DifficultyModifier, Question : updateQuestionDifficulty
     |||
   end
+  destroy QuestionGenerator
 return
 
 return CommandResult(true)
+destroy GameEnvironment
 
 @enduml

docs/uml/activerecall/ActiveRecallCreateEnvironmentSequenceDiagram.puml

@@ -14,8 +14,6 @@ endbox
 box "Active Recall" #lightblue
 participant ":GameEnvironment" as GameEnvironment #lightskyblue
 participant ":QuestionGenerator" as QuestionGenerator #lightskyblue
-participant ":DifficultyModifier" as DifficultyModifier #lightskyblue
-participant ":Question" as Question #lightskyblue
 endbox
 
 -> TestCommand : execute(moduleManager)

src/main/java/terminus/Terminus.java

@@ -24,6 +24,7 @@ public class Terminus {
 
     private ModuleManager moduleManager;
     private StorageManager storageManager;
+    private Path dataDirectory;
 
     private static final Path DATA_DIRECTORY = Path.of(System.getProperty("user.dir"), "data");
     private static final String MAIN_JSON = "main.json";
@@ -36,12 +37,13 @@ public static void main(String[] args) {
     }
 
     Terminus() {
-        this(Ui.getInstance(), MainCommandParser.getInstance());
+        this(Ui.getInstance(), MainCommandParser.getInstance(), DATA_DIRECTORY);
     }
 
-    Terminus(Ui ui, CommandParser parser) {
+    Terminus(Ui ui, CommandParser parser, Path dataDirectory) {
         this.ui = ui;
         this.parser = parser;
+        this.dataDirectory = dataDirectory;
     }
 
     /**
@@ -58,7 +60,7 @@ void initialize() {
             TerminusLogger.initializeLogger();
             TerminusLogger.info("Starting Terminus...");
             this.workspace = "";
-            this.storageManager = new StorageManager(DATA_DIRECTORY, MAIN_JSON);
+            this.storageManager = new StorageManager(dataDirectory, MAIN_JSON);
             this.moduleManager = this.storageManager.initialize();
         } catch (IOException e) {
             TerminusLogger.warning("Log file loading has failed.", e.fillInStackTrace());

src/main/java/terminus/activerecall/GameEnvironment.java

@@ -94,7 +94,7 @@ private int getUserFeedback() {
             difficulty = Integer.parseInt(input);
 
         } while (difficulty == INVALID_DIFFICULTY);
-        assert difficulty <= HARD_DIFFICULTY && difficulty >= -EASY_DIFFICULTY;
+        assert difficulty <= HARD_DIFFICULTY && difficulty >= EXIT_CODE;
         return difficulty;
     }
 

src/test/java/terminus/TerminusTest.java

@@ -4,9 +4,17 @@
 import static org.junit.jupiter.api.Assertions.assertTrue;
 
 import java.io.ByteArrayInputStream;
+import java.io.File;
+import java.io.IOException;
 import java.io.InputStream;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Comparator;
+import java.util.stream.Stream;
 import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.AfterEach;
 import org.junit.jupiter.api.BeforeAll;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 import terminus.parser.MainCommandParser;
 import terminus.ui.Ui;
@@ -26,6 +34,20 @@ static void afterAll() {
         System.setIn(oldInput);
     }
 
+    @BeforeEach
+    void setUp() {
+        TestFilePath.RESOURCE_DATA_FOLDER.toFile().mkdir();
+    }
+
+    @AfterEach
+    void tearDown() throws IOException {
+        try (Stream<Path> walk = Files.walk(TestFilePath.RESOURCE_DATA_FOLDER)) {
+            walk.sorted(Comparator.reverseOrder())
+                .map(Path::toFile)
+                .forEach(File::delete);
+        }
+    }
+
     @Test
     void run_exit_success() {
         String input = String.format("exit%s", LS);
@@ -38,7 +60,8 @@ void run_exit_success() {
     void run_invalidCommand_exit_success() {
         String input = String.format("exita%shelp%sexit%s", LS, LS, LS);
         InputStream in = new ByteArrayInputStream(input.getBytes());
-        Terminus terminus = new Terminus(new Ui(in), MainCommandParser.getInstance());
+        Terminus terminus = new Terminus(new Ui(in), MainCommandParser.getInstance(), 
+            TestFilePath.RESOURCE_DATA_FOLDER);
         terminus.run();
     }
 
@@ -51,23 +74,26 @@ void safety_test() {
 
     @Test
     void handleUserInput_success() {
-        Terminus terminus = new Terminus();
+        Terminus terminus = new Terminus(new Ui(System.in), MainCommandParser.getInstance(),
+            TestFilePath.RESOURCE_DATA_FOLDER);
         terminus.initialize();
         assertTrue(terminus.handleUserInput("exit").isExit());
     }
 
     @Test
     void handleUserInput_exceptionThrown_returnNull() {
-        Terminus terminus = new Terminus();
+        Terminus terminus = new Terminus(new Ui(System.in), MainCommandParser.getInstance(), 
+            TestFilePath.RESOURCE_DATA_FOLDER);
         terminus.initialize();
         assertNull(terminus.handleUserInput("exita"));
         assertNull(terminus.handleUserInput("module add"));
-        assertNull(terminus.handleUserInput("module delete 10"));
+        assertNull(terminus.handleUserInput("module delete " + Integer.MAX_VALUE));
     }
 
     @Test
     void handleCommandResult_success() {
-        Terminus terminus = new Terminus();
+        Terminus terminus = new Terminus(new Ui(System.in), MainCommandParser.getInstance(),
+            TestFilePath.RESOURCE_DATA_FOLDER);
         terminus.initialize();
         terminus.handleCommandResult(terminus.handleUserInput("module add \"test\""));
         terminus.handleCommandResult(terminus.handleUserInput("go test"));
@@ -83,10 +109,10 @@ void handleCommandResult_success() {
 
     @Test
     void handleStorage_success() {
-        Terminus terminus = new Terminus();
+        Terminus terminus = new Terminus(new Ui(System.in), MainCommandParser.getInstance(),
+            TestFilePath.RESOURCE_DATA_FOLDER);
         terminus.initialize();
         terminus.handleStorage(terminus.handleUserInput("module add \"test\""));
         terminus.handleStorage(terminus.handleUserInput("module delete 1"));
     }
-
 }

src/test/java/terminus/TestFilePath.java

@@ -5,6 +5,7 @@
 public class TestFilePath {
 
     public static final Path RESOURCE_FOLDER = Path.of("src", "test", "resources");
+    public static final Path RESOURCE_DATA_FOLDER = RESOURCE_FOLDER.resolve("data");
     public static final String FAULTY_FOLDER = "faulty";
     public static final String SAVE_FILE = "saveFile.json";
     public static final String MALFORMED_FILE = "malformedFile.json";