fix: missing enums are not immediately saved (#1940)

Aam-Digital · Jul 25, 2023 · 5028765 · 5028765
1 parent 484ee47
commit 5028765
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/src/app/core/configurable-enum/configurable-enum.service.spec.ts b/src/app/core/configurable-enum/configurable-enum.service.spec.ts
@@ -8,11 +8,7 @@ describe("ConfigurableEnumService", () => {
   let service: ConfigurableEnumService;
   let mockEntityMapper: jasmine.SpyObj<EntityMapperService>;
   beforeEach(async () => {
-    mockEntityMapper = jasmine.createSpyObj([
-      "save",
-      "loadType",
-      "receiveUpdates",
-    ]);
+    mockEntityMapper = jasmine.createSpyObj(["loadType", "receiveUpdates"]);
     mockEntityMapper.receiveUpdates.and.returnValue(NEVER);
     mockEntityMapper.loadType.and.resolveTo([]);
     await TestBed.configureTestingModule({
@@ -34,14 +30,12 @@ describe("ConfigurableEnumService", () => {
 
     expect(newEnum.getId()).toEqual("new-id");
     expect(newEnum.values).toEqual([]);
-    expect(mockEntityMapper.save).toHaveBeenCalledWith(newEnum);
     // returns same enum in consecutive calls
     expect(service.getEnum("new-id")).toBe(newEnum);
   });
 
   it("should not creat a new enum if the user is missing permissions", () => {
     spyOn(TestBed.inject(EntityAbility), "can").and.returnValue(false);
     expect(service.getEnum("new-id")).toBeUndefined();
-    expect(mockEntityMapper.save).not.toHaveBeenCalled();
   });
 });
diff --git a/src/app/core/configurable-enum/configurable-enum.service.ts b/src/app/core/configurable-enum/configurable-enum.service.ts
@@ -45,7 +45,6 @@ export class ConfigurableEnumService {
     ) {
       const newEnum = new ConfigurableEnum(id);
       this.cacheEnum(newEnum);
-      this.entityMapper.save(newEnum);
     }
     return this.enums.get(entityId);
   }