fix: missing enums are not immediately saved #1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-1940.aam-digital.net/ |
|
Kudos, SonarCloud Quality Gate passed!
|
sleidig
approved these changes
Jul 25, 2023
|
🎉 This PR is included in version 3.22.0-master.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it sometimes happens that users end up with a (new) empty enum object and the database has conflicts on enum documents.
This can happen when
Then a new enum is created and saved which will conflict with the existing enum once it is synced.
To prevent this we are not saving the empty enum immediately.
This means the enum is only saved if new options are added.
Once the existing enum is synced the newly created one will just be discarded.