Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better navigation for ChildrenCountDashboard #1152

Closed
TheSlimvReal opened this issue Mar 23, 2022 · 3 comments
Closed

Better navigation for ChildrenCountDashboard #1152

TheSlimvReal opened this issue Mar 23, 2022 · 3 comments

Comments

@TheSlimvReal
Copy link
Collaborator

Describe the bug
When clicking on one of the groupings in the ChildrenCountDashboard you are forwarded to the children overview and the children should be filtered based on the grouping that was clicked on.
Currently this is done by transforming the name of the grouping to lowercase.
This is not always correct and especially with configurable enums this should use the id of the enum instead.

Additional context
In the ChildrenCountDashboard the routing is done like this:

goToChildrenList(filterString: string) {
  const params = {};
  params[this.groupBy] = filterString.toLocaleLowerCase();

  const path = "/" + Child.ENTITY_TYPE.toLowerCase();
  this.router.navigate([path], { queryParams: params });
}

the filterString.toLowerCase is an assumption that is not always correct. Especially when this.groupBy is a configurable-enum property, the id of that enum should be used.

@TheSlimvReal
Copy link
Collaborator Author

duplicate #1242

Repository owner moved this from Todo to Done in All Tasks & Issues May 5, 2022
Repository owner moved this from Todo to Done in Important Fixes & Enhancements May 5, 2022
@TheSlimvReal TheSlimvReal mentioned this issue May 5, 2022
2 tasks
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.6.0-master.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants