Task module #1578
Merged
Task module #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basic structures
for easier overview of related components and simplified testing imports
# Conflicts: # src/app/core/entity-components/entity-select/display-entity-array/display-entity-array.stories.ts # src/app/core/entity-components/entity-select/display-entity/display-entity.stories.ts # src/app/core/entity-components/entity-select/edit-entity-array/entity-reference-array.stories.ts # src/app/core/entity-components/entity-select/edit-single-entity/entity-reference.stories.ts # src/app/core/entity-components/entity-select/entity-select.module.ts # src/app/core/entity-components/entity-select/entity-select/entity-select.component.spec.ts # src/app/core/entity-components/entity-select/entity-select/entity-select.stories.ts
|
Deployed to https://pr-1578.aam-digital.net/ |
Merged
TheSlimvReal
reviewed
Dec 8, 2022
# Conflicts: # src/app/core/entity-components/entity-select/edit-entity-array/edit-entity-array.component.ts # src/app/core/entity-components/entity-select/entity-select/entity-select.component.spec.ts # src/app/core/entity-components/entity-select/entity-select/entity-select.component.ts
Co-authored-by: Simon <simon@aam-digital.com>
There was a problem hiding this comment.
Looks fine so far.
I don't like the custom interval component very much. Instead, the filter selection could be 2 dropdowns, 1 for number (1-10), one for unit (days, weeks, months, years). This would also make to code much less complicated.
Whats missing:
- (Dashboard) active todos
- Logic behind intervals
.../tasks/recurring-interval/display-recurring-interval/display-recurring-interval.component.ts
Outdated
Show resolved
Hide resolved
src/app/features/tasks/tasks-related-to-entity/tasks-related-to-entity.component.ts
Outdated
Show resolved
Hide resolved
src/app/features/tasks/tasks-related-to-entity/tasks-related-to-entity.component.ts
Outdated
Show resolved
Hide resolved
src/app/features/tasks/recurring-interval/custom-interval/custom-interval.component.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon <simon@aam-digital.com>
# Conflicts: # src/app/child-dev-project/notes/dashboard-widgets/important-notes-dashboard/important-notes-dashboard.component.ts # src/app/core/dashboard/dashboard-list-widget/dashboard-list-widget.component.html # src/app/core/dashboard/dashboard-list-widget/dashboard-list-widget.component.spec.ts # src/app/core/dashboard/dashboard-list-widget/dashboard-list-widget.component.ts # src/app/core/entity-components/entity-list/EntityListConfig.ts # src/app/core/entity-components/entity-list/entity-list.component.html # src/app/core/entity-components/entity-subrecord/entity-subrecord/entity-subrecord.component.spec.ts # src/app/core/entity-components/entity-subrecord/entity-subrecord/entity-subrecord.component.ts # src/app/core/ui/search/search.component.ts
…y using the data type
TheSlimvReal
approved these changes
Jan 6, 2023
src/app/features/todos/todo-completion/todo-completion/todo-completion.component.html
Outdated
Show resolved
Hide resolved
src/app/features/todos/recurring-interval/custom-interval/custom-interval.component.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Simon <simon@aam-digital.com>
…om-interval.component.scss Co-authored-by: Simon <simon@aam-digital.com>
…mpletion.component.html Co-authored-by: Simon <simon@aam-digital.com>
# Conflicts: # src/app/app.module.ts # src/app/core/entity-components/entity-select/display-entity-array/display-entity-array.component.ts # src/app/core/entity-components/entity-select/edit-entity-array/entity-reference-array.stories.ts # src/app/core/entity-components/entity-select/edit-single-entity/entity-reference.stories.ts # src/app/core/entity-components/entity-utils/dynamic-form-components/edit-number/edit-number.stories.ts
|
Kudos, SonarCloud Quality Gate passed!
|
|
🎉 This PR is included in version 3.16.0-master.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
1 similar comment
|
🎉 This PR is included in version 3.16.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module to manage tasks similar to notes but as separate entities.