Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service worker should only be enabled once a user is logged in #1663

Closed
TheSlimvReal opened this issue Jan 12, 2023 · 1 comment
Closed

Service worker should only be enabled once a user is logged in #1663

TheSlimvReal opened this issue Jan 12, 2023 · 1 comment
Labels
Type: Improvement Improvement/Extension of existing feature with benefit for the user Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user

Comments

@TheSlimvReal
Copy link
Collaborator

Currently, the service worker is registered at the app start. As we are now also offering the app publicly as a form, this is unnecessarily caching a lot of files that will never be used.

The service worker module allows to add a registrationStrategy there a observable can be provided and the service worker will be registered once the observable emits a value. There we can use the LoginState to only register this once the user has logged in.

@TheSlimvReal TheSlimvReal added Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user Type: Improvement Improvement/Extension of existing feature with benefit for the user labels Jan 12, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Improvement/Extension of existing feature with benefit for the user Type: Refactoring / Technical Enh. Technical Enhancement without changes for the user
Projects
None yet
Development

No branches or pull requests

2 participants