Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: service worker is only registered once user logs in #1712

Merged
merged 5 commits into from
Mar 2, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Feb 8, 2023

see issue: #1663

Visible/Frontend Changes

--

Architectural/Backend Changes

  • service worker registration is only started after user is logged in

@github-actions
Copy link

github-actions bot commented Feb 8, 2023

Deployed to https://pr-1712.aam-digital.net/

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deployed PR / demo version does not allow to log in with demo:pass anymore (and does not do it automatically).

How can we test the install + offline etc. cases for this thoroughly? Does it need to be deployed specially?

@TheSlimvReal
Copy link
Collaborator Author

TheSlimvReal commented Mar 1, 2023

Sorry @sleidig I updated the deployment. I made a copy of the dev DB and deployed this PR there (see link above). Also installing and offline is working for me.
What do you mean by deployed specially?

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit 62fadce into master Mar 2, 2023
@TheSlimvReal TheSlimvReal deleted the sw_on_login branch March 2, 2023 17:16
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

TheSlimvReal added a commit that referenced this pull request Mar 16, 2023
TheSlimvReal added a commit that referenced this pull request Mar 16, 2023
TheSlimvReal added a commit that referenced this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants