-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: service worker is only registered once user logs in #1712
Conversation
Deployed to https://pr-1712.aam-digital.net/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
deployed PR / demo version does not allow to log in with demo:pass anymore (and does not do it automatically).
How can we test the install + offline etc. cases for this thoroughly? Does it need to be deployed specially?
Sorry @sleidig I updated the deployment. I made a copy of the dev DB and deployed this PR there (see link above). Also installing and offline is working for me. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
🎉 This PR is included in version 3.19.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
…)" This reverts commit 62fadce.
see issue: #1663
Visible/Frontend Changes
--
Architectural/Backend Changes