Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new option from enum popup window #1872

Closed
sleidig opened this issue May 4, 2023 · 3 comments · Fixed by #2040
Closed

add new option from enum popup window #1872

sleidig opened this issue May 4, 2023 · 3 comments · Fixed by #2040
Assignees
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: UX concerning user interface and in a broader sense user experience

Comments

@sleidig
Copy link
Member

sleidig commented May 4, 2023

As the dialog is offering to rename and delete options already, it would be helpful to also have the option to add completely new options not only from the dropdown field but also in its option edit dialog shown when clicking the tool icon.


Implementation details:

  • use npm run storybook to test and improve the component "Core / Entities / Edit Properties / Enum Dropdown / Primary"

  • Component / template to be extended: ConfigureEnumPopupComponent
    (add a button to "add new option" between the last existing field and the close button)
    image

  • current logic to add a new value to the options in EnumDropdownComponent: move this to ConfigurableEnumService and reuse

    private addNewOption(name: string) {
    const option = { id: name, label: name };
    this.enumEntity.values.push(option);
    this.entityMapper.save(this.enumEntity);
    return option;
    }

@sleidig sleidig added the Type: UX concerning user interface and in a broader sense user experience label May 4, 2023
@TheSlimvReal
Copy link
Collaborator

Seems to be more necessary than I expected. A lot of people only find the rename option but don't realise that you have to enter something in order to add a new option.

@sleidig sleidig moved this from Triage to Todo [community help wanted] in All Tasks & Issues Jun 22, 2023
@sleidig sleidig added the Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform label Jul 18, 2023
@sadaf895 sadaf895 self-assigned this Jul 28, 2023
@sleidig sleidig moved this from Todo [community help wanted] to In Progress in All Tasks & Issues Jul 31, 2023
@sleidig sleidig moved this from In Progress to In Review in All Tasks & Issues Nov 19, 2023
sleidig added a commit that referenced this issue Nov 19, 2023
closes #1872

---------

Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Nov 19, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.26.0-master.19 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Nov 19, 2023
sleidig added a commit that referenced this issue Nov 19, 2023
closes #1872

---------

Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Status: Community Help Wanted (good first issue) simple tasks that don't require understanding every last detail of our platform Type: UX concerning user interface and in a broader sense user experience
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants