Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extend the total calculations below a subrecord list (generalize educational-material component) #2004

Closed
sleidig opened this issue Sep 18, 2023 · 6 comments · Fixed by #2017 or #2029
Closed

extend the total calculations below a subrecord list (generalize educational-material component) #2004

sleidig opened this issue Sep 18, 2023 · 6 comments · Fixed by #2017 or #2029
Assignees
@brajesh-lab
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)

Comments

@sleidig
Copy link
Member

sleidig commented Sep 18, 2023 •
edited
Loading

As a user I want to quickly get an overview and summary of a list of data, like the average number of pencils handed out to a child.

We already have a very basic summary of total amounts in the EducationalMaterialComponent (example in demo system).
Apart from a simple summed up total, some use cases required to see an average of the values in a table. Also, this component should become more generic and not tied to the EducationMaterial entity type anymore.

  • add the option to display averages in the summary
  • extend the config object to allow configuration whether sums and/or averages should be displayed
  • improve the UI of how the summary is presented (?)
  • generalize the EducationalMaterialComponent to be usable for any entity type (similar to the RelatedEntitiesComponent)

to be designed in collaboration with the client having the specific requirement
@sleidig sleidig moved this from Triage to Todo [community help wanted] in All Tasks & Issues Sep 18, 2023
@sleidig sleidig added the CC label Sep 20, 2023
@rudresh rudresh moved this from Todo [help wanted] to In Progress in All Tasks & Issues Oct 4, 2023
brajesh-lab pushed a commit that referenced this issue Oct 6, 2023
#2004 - extended the summary to include average in Educational material
a50741f
brajesh-lab pushed a commit that referenced this issue Oct 6, 2023
#2004 - extended the summary to include average in Educational material
e2a4410
brajesh-lab pushed a commit that referenced this issue Oct 6, 2023
#2004 - extended the summary to include average in Educational material
4657bc8
@brajesh-lab brajesh-lab mentioned this issue Oct 6, 2023
Merged
2 tasks
brajesh-lab pushed a commit that referenced this issue Oct 6, 2023
#2004-rounding off the numbers in average
a351391
brajesh-lab pushed a commit that referenced this issue Oct 9, 2023
#2004 - refactor and cleanup
1ffdeb8
brajesh-lab pushed a commit that referenced this issue Oct 9, 2023
#2004 - refactor for codeclimate
268c56f
@brajesh-lab brajesh-lab moved this from In Progress to In Review in All Tasks & Issues Oct 9, 2023
@brajesh-lab brajesh-lab assigned brajesh-lab and unassigned rudresh Oct 9, 2023
brajesh-lab pushed a commit that referenced this issue Oct 11, 2023
#2004 - Removed unit test for router from educational material
1d693cf
brajesh-lab pushed a commit that referenced this issue Oct 11, 2023
#2004 - removed unused imports
7a9e8ab
brajesh-lab pushed a commit that referenced this issue Oct 12, 2023
#2004 - extended the summary to include average in Educational material
a6dad57
brajesh-lab pushed a commit that referenced this issue Oct 12, 2023
#2004 - extended the summary to include average in Educational material
5f08b33
brajesh-lab pushed a commit that referenced this issue Oct 12, 2023
#2004 - extended the summary to include average in Educational material
3034b9c
brajesh-lab pushed a commit that referenced this issue Oct 12, 2023
#2004-rounding off the numbers in average
3a38701
brajesh-lab pushed a commit that referenced this issue Oct 12, 2023
#2004 - refactor and cleanup
a287546
brajesh-lab pushed a commit that referenced this issue Oct 12, 2023
#2004 - refactor for codeclimate
89973f9
brajesh-lab pushed a commit that referenced this issue Oct 12, 2023
#2004 - Removed unit test for router from educational material
580fbb9
brajesh-lab pushed a commit that referenced this issue Oct 12, 2023
#2004 - removed unused imports
a416a58
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Oct 12, 2023
sleidig added a commit that referenced this issue Oct 12, 2023
@brajesh-lab @sleidig
feat: educational material summary can show averages (#2017)
d00ce3a 
see #2004 

---------

Co-authored-by: Sebastian <sebastian@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.25.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Oct 12, 2023
@sleidig
Copy link
Member Author

sleidig commented Oct 12, 2023

@brajesh-lab I have an approach in mind how to easily generalize the component for any entity type. Will implement a draft and mark you to review and also look at it then.

sleidig added a commit that referenced this issue Oct 13, 2023
@sleidig
feat(core): generalize related entities with summary component
2b1d059 
to be usable with any entity type, not just EducationalMaterial

closes #2004
@sleidig sleidig mentioned this issue Oct 13, 2023
Merged
sleidig added a commit that referenced this issue Oct 13, 2023
@sleidig
feat(core): generalize related entities with summary component
1efcc2e 
to be usable with any entity type, not just EducationalMaterial

closes #2004
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Oct 13, 2023
sleidig added a commit that referenced this issue Oct 16, 2023
@sleidig
Generalized RelatedEntitiesWithSummary (from EducationalMaterialCompo…
616fc9d 
…nent) (#2029)

* feat(core): generalize related entities with summary component

to be usable with any entity type, not just EducationalMaterial

closes #2004
Co-authored-by: Simon <simon@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.25.1-master.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.25.1-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.25.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brajesh-lab brajesh-lab

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
4 participants
@rudresh @sleidig @aam-digital-ci @brajesh-lab