Extend educational material summary #2017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-2017.aam-digital.net/ |
sleidig
requested changes
Oct 10, 2023
There was a problem hiding this comment.
Thanks, @brajesh-lab the functionality looks good!
The way our configuration logic works, the config should be received through an @Input, not from the Route, however. I am explaining the concept inline commented in the code.
...ildren/educational-material/educational-material-component/educational-material.component.ts
Outdated
Show resolved
Hide resolved
added 12 commits
October 12, 2023 11:29
brajesh-lab
force-pushed
the
extend-educational-material-summary
branch
from
5fb69d1 to
f5f9424
Compare
sleidig
requested changes
Oct 12, 2023
...dren/educational-material/educational-material-component/educational-material.component.html
Outdated
Show resolved
Hide resolved
...ildren/educational-material/educational-material-component/educational-material.component.ts
Outdated
Show resolved
Hide resolved
added 2 commits
October 12, 2023 16:00
sleidig
reviewed
Oct 12, 2023
...ildren/educational-material/educational-material-component/educational-material.component.ts
Outdated
Show resolved
Hide resolved
…ional-material-component/educational-material.component.ts
|
🎉 This PR is included in version 3.25.0-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.25.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2004
Visible/Frontend Changes
Architectural/Backend Changes