Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unrelated changes #2196

Merged
merged 34 commits into from
Feb 5, 2024
Merged

Fix unrelated changes #2196

merged 34 commits into from
Feb 5, 2024

Conversation

TheSlimvReal
Copy link
Collaborator

@TheSlimvReal TheSlimvReal commented Jan 23, 2024

closes: #2195

Architectural/Backend Changes

  • Generalize filter logic for RelatedEntitiesComponent
  • Infer property based on provided entities
  • Generalize new record factory logic

Copy link

Deployed to https://pr-2196.aam-digital.net/

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional testing:

  • creating new from ActivitiesOverview (school -> students) is broken ("Cannot set property isActive")
  • Todos not displayed in Child details anymore

TheSlimvReal and others added 4 commits January 31, 2024 13:04
…component.ts

Co-authored-by: Sebastian <sebastian@aam-digital.com>
# Conflicts:
#	src/app/child-dev-project/children/aser/aser-component/aser.component.ts
#	src/app/child-dev-project/children/educational-material/model/educational-material.ts
#	src/app/child-dev-project/children/health-checkup/health-checkup-component/health-checkup.component.ts
#	src/app/child-dev-project/notes/notes-related-to-entity/notes-related-to-entity.component.spec.ts
#	src/app/child-dev-project/notes/notes-related-to-entity/notes-related-to-entity.component.ts
#	src/app/child-dev-project/schools/child-school-overview/child-school-overview.component.ts
#	src/app/core/entity-details/related-entities/related-entities.component.spec.ts
#	src/app/core/entity-details/related-time-period-entities/related-time-period-entities.component.spec.ts
#	src/app/features/todos/todos-related-to-entity/todos-related-to-entity.component.ts
@TheSlimvReal TheSlimvReal requested a review from sleidig February 2, 2024 13:17
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well now 👍

I will look into completely removing a few of those components - the constant testing across these is not really feasible.

Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TheSlimvReal I have manually removed the Aser and HealthCheck components from the few production servers where they are used and deleted those components here.
Do have a final look over my changes and feel free to merge then.

TheSlimvReal and others added 2 commits February 5, 2024 08:58
Co-authored-by: Sebastian <sebastian@aam-digital.com>
@TheSlimvReal TheSlimvReal merged commit 142f68d into master Feb 5, 2024
7 checks passed
@TheSlimvReal TheSlimvReal deleted the fix_unrelated_changes branch February 5, 2024 08:58
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.31.1-master.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Feb 5, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.31.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong entities are added to tables
3 participants