-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unrelated changes #2196
Fix unrelated changes #2196
Conversation
Deployed to https://pr-2196.aam-digital.net/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional testing:
- creating new from ActivitiesOverview (school -> students) is broken ("Cannot set property isActive")
- Todos not displayed in Child details anymore
src/app/child-dev-project/notes/notes-related-to-entity/notes-related-to-entity.component.ts
Show resolved
Hide resolved
src/app/core/entity-details/related-entities/related-entities.component.spec.ts
Outdated
Show resolved
Hide resolved
src/app/core/entity-details/related-entities/related-entities.component.spec.ts
Show resolved
Hide resolved
src/app/core/entity-details/related-entities/related-entities.component.ts
Show resolved
Hide resolved
src/app/core/entity-details/related-entities/related-entities.component.ts
Outdated
Show resolved
Hide resolved
src/app/core/entity-details/related-entities/related-entities.component.ts
Outdated
Show resolved
Hide resolved
src/app/features/todos/todos-related-to-entity/todos-related-to-entity.component.ts
Outdated
Show resolved
Hide resolved
…component.ts Co-authored-by: Sebastian <sebastian@aam-digital.com>
# Conflicts: # src/app/child-dev-project/children/aser/aser-component/aser.component.ts # src/app/child-dev-project/children/educational-material/model/educational-material.ts # src/app/child-dev-project/children/health-checkup/health-checkup-component/health-checkup.component.ts # src/app/child-dev-project/notes/notes-related-to-entity/notes-related-to-entity.component.spec.ts # src/app/child-dev-project/notes/notes-related-to-entity/notes-related-to-entity.component.ts # src/app/child-dev-project/schools/child-school-overview/child-school-overview.component.ts # src/app/core/entity-details/related-entities/related-entities.component.spec.ts # src/app/core/entity-details/related-time-period-entities/related-time-period-entities.component.spec.ts # src/app/features/todos/todos-related-to-entity/todos-related-to-entity.component.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well now 👍
I will look into completely removing a few of those components - the constant testing across these is not really feasible.
src/app/core/entity-details/related-entities/related-entities.component.ts
Show resolved
Hide resolved
src/app/child-dev-project/children/aser/aser-component/aser.component.ts
Outdated
Show resolved
Hide resolved
...ild-dev-project/children/health-checkup/health-checkup-component/health-checkup.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheSlimvReal I have manually removed the Aser and HealthCheck components from the few production servers where they are used and deleted those components here.
Do have a final look over my changes and feel free to merge then.
Co-authored-by: Sebastian <sebastian@aam-digital.com>
🎉 This PR is included in version 3.31.1-master.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 3.31.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
closes: #2195
Architectural/Backend Changes
RelatedEntitiesComponent
property
based on provided entities