Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'+' button not working in TodosRelatedToEntity and NotesRelatedToEntity #2188

Closed
TheSlimvReal opened this issue Jan 23, 2024 · 2 comments · Fixed by #2192
Closed

'+' button not working in TodosRelatedToEntity and NotesRelatedToEntity #2188

TheSlimvReal opened this issue Jan 23, 2024 · 2 comments · Fixed by #2192
Assignees
@sleidig
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Bug

Comments

@TheSlimvReal
Copy link
Collaborator

To Reproduce
Steps to reproduce the behavior:

  1. Go to Child Details
  2. Go to 'Notes and Tasks'
  3. Click on '+' in any table
  4. Nothing happens

Expected behavior
It should open the custom popup for the respective entity.

Additional context
It only seems to happen in tables where a custom popup component is used (NoteDetails / TodoDetails) instead of the generic RowDetailsComponent.
@TheSlimvReal TheSlimvReal mentioned this issue Jan 23, 2024
Merged
4 tasks
sleidig added a commit that referenced this issue Jan 23, 2024
@sleidig
fix: plus button in notes / tasks of child correctly opens popup again
422158d 
closes #2188
@sleidig sleidig self-assigned this Jan 23, 2024
@sleidig sleidig mentioned this issue Jan 23, 2024
Closed
@sleidig sleidig moved this from Triage to In Review in All Tasks & Issues Jan 23, 2024
@TheSlimvReal TheSlimvReal mentioned this issue Jan 23, 2024
Merged
1 task
TheSlimvReal added a commit that referenced this issue Jan 23, 2024
@TheSlimvReal @sleidig
fix: plus button in notes / tasks of child correctly opens popup again (
048de5f 
#2192)

Closes #2188

Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
@github-project-automation github-project-automation bot moved this from In Review to Done in All Tasks & Issues Jan 23, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.29.1-master.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Jan 23, 2024
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.30.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Jan 25, 2024
@TheSlimvReal TheSlimvReal linked a pull request Jan 29, 2024 that will close this issue
Fix unrelated changes #2196
Merged
3 tasks
@TheSlimvReal TheSlimvReal removed a link to a pull request Jan 29, 2024
Fix unrelated changes #2196
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sleidig sleidig

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Bug
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
3 participants
@sleidig @TheSlimvReal @aam-digital-ci