[Simon] fix: plus button in notes / tasks of child correctly opens popup again #2192
Conversation
|
Deployed to https://pr-2192.aam-digital.net/ |
TheSlimvReal
changed the title
There was a problem hiding this comment.
I like your implementation. Seems to work well - I did not find a "Changed after checked" warning.
The updates of new notes and todos currently throws in everything - even unrelated entities. But I would hope to fix this with further index generalization at some point, so maybe acceptable right now.
src/app/core/common-components/entities-table/entities-table.component.ts
Show resolved
Hide resolved
| async ngOnInit() { | ||
| this.entries = await this.loadDataFor(this.entity.getId(true)); | ||
| override async initData() { | ||
| this.data = await this.loadDataFor(this.entity.getId(true)); |
There was a problem hiding this comment.
| this.data = await this.loadDataFor(this.entity.getId(true)); | |
| // TODO: RelatedEntitiesComponent listening to entity updates currently adds any task (also unrelated to this entity) -> add better filters? | |
| this.data = await this.loadDataFor(this.entity.getId(true)); |
There was a problem hiding this comment.
We already have the same issue in NotesRelatedToEntities so I would rather collect this in an issue -> #2195
…omponent.ts Co-authored-by: Sebastian <sebastian@aam-digital.com>
|
🎉 This PR is included in version 3.29.1-master.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.30.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closes #2188
Alternative to #2190
TODO
AttendanceDetailsComponent