Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add labels to the entities (for different language versions) #886

Closed
christophscheuing opened this issue Jul 13, 2021 · 4 comments · Fixed by #1531
Closed

Add labels to the entities (for different language versions) #886

christophscheuing opened this issue Jul 13, 2021 · 4 comments · Fixed by #1531
Assignees
Labels
Type: Improvement Improvement/Extension of existing feature with benefit for the user

Comments

@christophscheuing
Copy link
Contributor

christophscheuing commented Jul 13, 2021

Right now, there's no separate label for entities like "Child" or "School". E.g. when trying to delete a child from the child details view, the message "Are you sure you want to delete this Child ?" is shown, where "Child" is taken directly from the entity type. It is not read from the configuration and at the current state it is not possible to add different language versions for this label.

One problem might be that the entity name is also relevant for the URL, so care should be taken when adding the label feature.

**also see #1056 **

@christophscheuing christophscheuing added Type: Feature new user-facing feature discuss labels Jul 13, 2021
@sleidig
Copy link
Member

sleidig commented Jul 20, 2021

we have an alias table to rename the entity types (e.g. from "School" to "Team") already (see https://github.com/Aam-Digital/ndb-core/blob/master/src/app/core/entity-components/entity-details/entity-details.component.ts) but that is not feasible to also handle translations. We should replace that existing approach.

The best way to handle this is probably to have a label property for the entity config, so that any instance can just rename that just like menu items are renamed (in config-fix).

@sleidig sleidig added Type: Improvement Improvement/Extension of existing feature with benefit for the user and removed discuss Type: Feature new user-facing feature labels Jul 20, 2021
@sleidig sleidig added this to the Translatable UI (i18n) milestone Jul 20, 2021
@sleidig sleidig mentioned this issue Oct 21, 2021
4 tasks
@sleidig sleidig moved this to Triage in All Tasks & Issues Feb 8, 2022
@sleidig sleidig moved this from Triage to Todo in All Tasks & Issues Feb 8, 2022
@sleidig
Copy link
Member

sleidig commented Feb 22, 2022

This is related to #1056 (defining entities completely via config without a typescript class) insofar as that other issue would supersede this and already cover the label as well. It could still make sense to first implement this simpler improvement, however.

@sleidig sleidig moved this from Priority to Todo in Important Fixes & Enhancements Oct 31, 2022
@sleidig sleidig moved this from Todo to Priority in Important Fixes & Enhancements Nov 10, 2022
@sleidig sleidig self-assigned this Nov 10, 2022
@sleidig sleidig moved this from Priority to In Progress in Important Fixes & Enhancements Nov 10, 2022
sleidig added a commit that referenced this issue Nov 10, 2022
@sleidig sleidig moved this from Todo to In Review in All Tasks & Issues Nov 10, 2022
sleidig added a commit that referenced this issue Nov 10, 2022
Repository owner moved this from In Progress to Done in Important Fixes & Enhancements Nov 11, 2022
Repository owner moved this from In Review to Done in All Tasks & Issues Nov 11, 2022
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.14.0-master.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.14.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Improvement Improvement/Extension of existing feature with benefit for the user
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants