Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UX of "Add Child" in school details view #982

Closed
sleidig opened this issue Sep 10, 2021 · 6 comments
Closed

Improve UX of "Add Child" in school details view #982

sleidig opened this issue Sep 10, 2021 · 6 comments
Assignees
Labels
Type: UX concerning user interface and in a broader sense user experience

Comments

@sleidig
Copy link
Member

sleidig commented Sep 10, 2021

A few aspects about the form to add a child to a school from the school details view could still be polished further:

  • The child select does not open a dropdown when clicking into it, only when starting to type (in other forms this is opening, e.g. RecurringActivity details to add participants)
  • The purpose of "From" and "To" fields has often been unclear to users, we should add tooltip explanations.
  • Can we use the same component in the school details that we use in the child details, also offering to remove a child, etc.?
  • Is there a way to label to button more generically (for some customers we talk of "participants" instead of children), maybe related to Add labels to the entities (for different language versions) #886
@sleidig sleidig added the Type: UX concerning user interface and in a broader sense user experience label Sep 10, 2021
@TheSlimvReal
Copy link
Collaborator

Regarding the button: The name can be changed by providing a different label for the childId property of the ChildSchoolRelation entity.

@TheSlimvReal
Copy link
Collaborator

Regarding the deleting: We can't use the basic logic of the EntitySubrecord there because currently we are actually displaying the children, not the ChildSchoolRelation objects, which means the delete button would delete the child and not just the child's participation at the school. To make a more similar look and feel to the component in the child details view, we could instead display the ChildSchoolRelation, which would then only show the ChildBlockComponent (not the age as a additional column), but it would allow to use all the default behavior of the EntitySubrecordComponent (creating , editing, deleting out of the box).
Otherwise we would need to make the delete behavior overwritable

@sleidig
Copy link
Member Author

sleidig commented Sep 13, 2021

True. I think for logical consistence doing it the same way as in the PreviousSchoolsComponent in the Child Details would make sense (i.e. displaying the school block and ChildSchoolRelation infos)

@TheSlimvReal
Copy link
Collaborator

TheSlimvReal commented Sep 15, 2021

  • Select single entity should automatically open the dropdown when selected
  • Add description for from and to button e.g. Date at which the child started at the school
  • Make the ChildrenOverviewComponent more similar to the PreviousSchoolsComponent. It should display the columns childId, schoolClass, start, end, result and the Add Child button should be removed and instead the add button from the EntitySubrecord should be used.

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 2.58.0-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 2.58.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: UX concerning user interface and in a broader sense user experience
Projects
None yet
Development

No branches or pull requests

4 participants