-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor edit single entity component #988
Conversation
Deployed to https://test-deployment-pr-988.herokuapp.com/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the look and feel of it! Thank you for taking this up. I requested some changes but I can also fix this later.
...ts/entity-utils/dynamic-form-components/edit-single-entity/edit-single-entity.component.html
Outdated
Show resolved
Hide resolved
...ents/entity-utils/dynamic-form-components/edit-single-entity/edit-single-entity.component.ts
Outdated
Show resolved
Hide resolved
...ents/entity-utils/dynamic-form-components/edit-single-entity/edit-single-entity.component.ts
Show resolved
Hide resolved
...ents/entity-utils/dynamic-form-components/edit-single-entity/edit-single-entity.component.ts
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the final adjustments. Works very well now
🎉 This PR is included in version 2.58.0-master.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎉 This PR is included in version 2.58.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
see issue: #982
Visible/Frontend Changes