Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Child list - UX improvement #1001

Merged
merged 18 commits into from
Sep 25, 2021
Merged

Child list - UX improvement #1001

merged 18 commits into from
Sep 25, 2021

Conversation

kirtijadhav
Copy link
Contributor

see issue: #982

Visible/Frontend Changes

  • Select single entity should automatically open the dropdown when selected
  • Add description for from and to button e.g. Date at which the child started at the school
  • Make the ChildrenOverviewComponent more similar to the PreviousSchoolsComponent. It should display the columns childId, schoolClass, start, end, result and the Add Child button should be removed and instead the add button from the EntitySubrecord should be used.

@github-actions
Copy link
Contributor

Deployed to https://test-deployment-pr-1001.herokuapp.com/

TheSlimvReal
TheSlimvReal approved these changes Sep 24, 2021
View reviewed changes
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, very nice. Thank you!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit 590c145 into master Sep 25, 2021
@TheSlimvReal TheSlimvReal deleted the child-list branch September 25, 2021 15:10
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 2.58.0-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 2.58.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSlimvReal TheSlimvReal TheSlimvReal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kirtijadhav @aam-digital-ci @TheSlimvReal