Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add child details #999

Closed
wants to merge 31 commits into from
Closed

Add child details #999

wants to merge 31 commits into from

Conversation

kirtijadhav
Copy link
Contributor

@kirtijadhav kirtijadhav commented Sep 20, 2021 •
edited
Loading

see issue: #982

Visible/Frontend Changes

  • Select single entity should automatically open the dropdown when selected
  • Add description for from and to button e.g. Date at which the child started at the school
  • Make the ChildrenOverviewComponent more similar to the PreviousSchoolsComponent. It should display the columns childId, schoolClass, start, end, result and the Add Child button should be removed and instead the add button from the EntitySubrecord should be used.

TheSlimvReal and others added 30 commits August 9, 2021 15:39
@TheSlimvReal
added property schema for childId of ChildSchoolRelation
6eaaac1
@kirtijadhav
- add child new button
3d66fdd
@kirtijadhav
Merge branch 'master' into add-children-from-school
4088904
@kirtijadhav
- added style to the button
85c3b09
@kirtijadhav
Merge remote-tracking branch 'origin/add-children-from-school' into a…
9133723 
…dd-children-from-school
@kirtijadhav
- added style to the button
8e107b9
@kirtijadhav
- fix button style
03fc00d
@TheSlimvReal
Merge branch 'master' into add-children-from-school
6d12fa3
@kirtijadhav
- fix button style again
82ca491
@kirtijadhav
Merge remote-tracking branch 'origin/add-children-from-school' into a…
bccd822 
…dd-children-from-school
@kirtijadhav
- remove consol.log for the button
92bff9a
@kirtijadhav
- run tests
93d3493
@kirtijadhav
- angular test
f3eee8a 
- fix run tests
@kirtijadhav
- add translation
fdb2434
@kirtijadhav
- add stories for add child
a35040d
@kirtijadhav
- added autocomplete filter to add new child
0691ded
@kirtijadhav
Merge remote-tracking branch 'origin/master' into add-children-from-s…
9357c7b 
…chool

# Conflicts:
#	src/app/core/session/session-service/online-session.service.ts
#	src/locale/messages.de.xlf
#	src/locale/messages.xlf
@kirtijadhav
- fix translation
5a1e38d
@kirtijadhav
- run tests
edab2ca
@kirtijadhav
- run tests
562f1b0
@kirtijadhav
- add new child to list
c6ec3a4
@kirtijadhav
- add child to the list
428c176
@TheSlimvReal
Merge remote-tracking branch 'origin/master' into add-children-from-s…
ef35f2c 
…chool

# Conflicts:
#	src/app/child-dev-project/schools/children-overview/children-overview.component.spec.ts
@TheSlimvReal
merged master
8ea67f0
@kirtijadhav
- fix display entity
e7653b1
@kirtijadhav
- run tests
5296b1a
@kirtijadhav
Merge remote-tracking branch 'origin/add-children-from-school' into a…
065d089 
…dd-children-from-school
@kirtijadhav
- run tests (lint)
d808056
@kirtijadhav
- fix child list for add child field
4c0e7fe
@kirtijadhav
- fix child list for add child field
a7a3c6b 
- add tooltip for label
@kirtijadhav kirtijadhav marked this pull request as ready for review September 20, 2021 16:40
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
13.8% 13.8% Duplication

@sleidig sleidig deleted the add-child-details branch December 7, 2021 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirtijadhav @TheSlimvReal