Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added pagination to shortcut widget #1738

Merged
merged 4 commits into from
Mar 2, 2023
Merged

fix: added pagination to shortcut widget #1738

merged 4 commits into from
Mar 2, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

see issue: #1692

Visible/Frontend Changes

  • [x]
  • [ ]

Architectural/Backend Changes

  • [x]
  • [ ]

@github-actions
Copy link

Deployed to https://pr-1738.aam-digital.net/

sleidig
sleidig reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we hide pagination if there are less then one page lenght elements? Here this adds unnecessary complexity:
image

sleidig
sleidig approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😃

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal TheSlimvReal merged commit 42295d0 into master Mar 2, 2023
@TheSlimvReal TheSlimvReal deleted the pagination branch March 2, 2023 09:50
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSlimvReal @aam-digital-ci @sleidig