Anonymization & Archive functionality #2012
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in preparation of implementing anonymization (#1674) --------- This functionality has been developed for the project “codo”. codo is developed under the projects “Landungsbrücken – Patenschaften in Hamburg stärken” and “openTransfer Patenschaften”. It is funded through the program “Menschen stärken Menschen” by the German Federal Ministry of Family Affairs, Senior Citizens, Women and Youth. More information at https://github.com/codo-mentoring “Landungsbrücken – Patenschaften in Hamburg stärken” is a project of BürgerStiftung Hamburg in cooperation with the Mentor.Ring Hamburg. With a mix of networking opportunities, capacity building and financial support the project strengthens Hamburg’s scene of mentoring projects since its founding in 2016. The “Stiftung Bürgermut” foundation since 2007 supports the digital and real exchange of experiences and connections of active citizens. Within the federal program “Menschen stärken Menschen” the foundation as part of its program “openTransfer Patenschaften” offers support services for connecting, spreading and upskilling mentoring organisations across Germany. Diese Funktion wurde entwickelt für das Projekt codo. codo wird entwickelt im Rahmen der Projekte Landungsbrücken – Patenschaften in Hamburg stärken und openTransfer Patenschaften. Er ist gefördert durch das Bundesprogramm Menschen stärken Menschen des Bundesministeriums für Familie, Senioren, Frauen und Jugend. Mehr Informationen unter https://github.com/codo-mentoring “Landungsbrücken – Patenschaften in Hamburg stärken” ist ein Projekt der BürgerStiftung Hamburg in Kooperation mit dem Mentor.Ring Hamburg. Mit einer Mischung aus Vernetzungsangeboten, Qualifizierungsmaßnahmen und finanzieller Förderung stärkt das Projekt die Hamburger Szene der Patenschaftsprojekte seit der Gründung im Jahr 2016. Die Stiftung Bürgermut fördert seit 2007 den digitalen und realen Erfahrungsaustausch und die Vernetzung von engagierten Bürger:innen. Innerhalb des Bundesprogramms „Menschen stärken Menschen” bietet die Stiftung im Rahmen ihres Programms openTransfer Patenschaften Unterstützungsleistungen zur Vernetzung, Verbreitung und Qualifizierung von Patenschafts- und Mentoringorganisationen bundesweit. Co-authored-by: codo-mentoring <117934638+codo-mentoring@users.noreply.github.com>
|
Deployed to https://pr-2012.aam-digital.net/ |
# Conflicts: # src/app/core/entity/entity-remove.service.spec.ts # src/app/core/entity/entity-remove.service.ts
+ full test cases (except cascading related)
…erty --------- This functionality has been developed for the project “codo”. codo is developed under the projects “Landungsbrücken – Patenschaften in Hamburg stärken” and “openTransfer Patenschaften”. It is funded through the program “Menschen stärken Menschen” by the German Federal Ministry of Family Affairs, Senior Citizens, Women and Youth. More information at https://github.com/codo-mentoring “Landungsbrücken – Patenschaften in Hamburg stärken” is a project of BürgerStiftung Hamburg in cooperation with the Mentor.Ring Hamburg. With a mix of networking opportunities, capacity building and financial support the project strengthens Hamburg’s scene of mentoring projects since its founding in 2016. The “Stiftung Bürgermut” foundation since 2007 supports the digital and real exchange of experiences and connections of active citizens. Within the federal program “Menschen stärken Menschen” the foundation as part of its program “openTransfer Patenschaften” offers support services for connecting, spreading and upskilling mentoring organisations across Germany. Diese Funktion wurde entwickelt für das Projekt codo. codo wird entwickelt im Rahmen der Projekte Landungsbrücken – Patenschaften in Hamburg stärken und openTransfer Patenschaften. Er ist gefördert durch das Bundesprogramm Menschen stärken Menschen des Bundesministeriums für Familie, Senioren, Frauen und Jugend. Mehr Informationen unter https://github.com/codo-mentoring “Landungsbrücken – Patenschaften in Hamburg stärken” ist ein Projekt der BürgerStiftung Hamburg in Kooperation mit dem Mentor.Ring Hamburg. Mit einer Mischung aus Vernetzungsangeboten, Qualifizierungsmaßnahmen und finanzieller Förderung stärkt das Projekt die Hamburger Szene der Patenschaftsprojekte seit der Gründung im Jahr 2016. Die Stiftung Bürgermut fördert seit 2007 den digitalen und realen Erfahrungsaustausch und die Vernetzung von engagierten Bürger:innen. Innerhalb des Bundesprogramms „Menschen stärken Menschen” bietet die Stiftung im Rahmen ihres Programms openTransfer Patenschaften Unterstützungsleistungen zur Vernetzung, Verbreitung und Qualifizierung von Patenschafts- und Mentoringorganisationen bundesweit. --------- Co-authored-by: codo-mentoring <117934638+codo-mentoring@users.noreply.github.com>
…erty --------- This functionality has been developed for the project “codo”. codo is developed under the projects “Landungsbrücken – Patenschaften in Hamburg stärken” and “openTransfer Patenschaften”. It is funded through the program “Menschen stärken Menschen” by the German Federal Ministry of Family Affairs, Senior Citizens, Women and Youth. More information at https://github.com/codo-mentoring “Landungsbrücken – Patenschaften in Hamburg stärken” is a project of BürgerStiftung Hamburg in cooperation with the Mentor.Ring Hamburg. With a mix of networking opportunities, capacity building and financial support the project strengthens Hamburg’s scene of mentoring projects since its founding in 2016. The “Stiftung Bürgermut” foundation since 2007 supports the digital and real exchange of experiences and connections of active citizens. Within the federal program “Menschen stärken Menschen” the foundation as part of its program “openTransfer Patenschaften” offers support services for connecting, spreading and upskilling mentoring organisations across Germany. Diese Funktion wurde entwickelt für das Projekt codo. codo wird entwickelt im Rahmen der Projekte Landungsbrücken – Patenschaften in Hamburg stärken und openTransfer Patenschaften. Er ist gefördert durch das Bundesprogramm Menschen stärken Menschen des Bundesministeriums für Familie, Senioren, Frauen und Jugend. Mehr Informationen unter https://github.com/codo-mentoring “Landungsbrücken – Patenschaften in Hamburg stärken” ist ein Projekt der BürgerStiftung Hamburg in Kooperation mit dem Mentor.Ring Hamburg. Mit einer Mischung aus Vernetzungsangeboten, Qualifizierungsmaßnahmen und finanzieller Förderung stärkt das Projekt die Hamburger Szene der Patenschaftsprojekte seit der Gründung im Jahr 2016. Die Stiftung Bürgermut fördert seit 2007 den digitalen und realen Erfahrungsaustausch und die Vernetzung von engagierten Bürger:innen. Innerhalb des Bundesprogramms „Menschen stärken Menschen” bietet die Stiftung im Rahmen ihres Programms openTransfer Patenschaften Unterstützungsleistungen zur Vernetzung, Verbreitung und Qualifizierung von Patenschafts- und Mentoringorganisationen bundesweit. --------- Co-authored-by: codo-mentoring <117934638+codo-mentoring@users.noreply.github.com>
# Conflicts: # src/app/core/common-components/entity-form/entity-form/entity-form.component.ts
TheSlimvReal
requested changes
Oct 13, 2023
There was a problem hiding this comment.
I really like how most of the anonymization/archiving logic is found in very few places. Really good approach to it. The entity remove service gets quite big, especially all the tests around anonymization. But I also see the shared logic between the functions.
| return value; | ||
| } | ||
|
|
||
| await this.removeService.anonymize(referencedEntity); |
There was a problem hiding this comment.
In my understanding, this is only called if the property is marked as retain:anonymized. So in the retain case, no cascading action would happen. Is this expected?
There was a problem hiding this comment.
Yes, the logic for direct references (indirect for cascading action are not implemented here yet) currently would be:
- "retain" -> keep unchanged
- "remove" (i.e. no explicit anonymize action configured) -> reference removed, related entity kept unchanged (:question: maybe not always what we want)
- "retain-anonymized" -> trigger "cascading" anonymization (and keep reference)
This is probably not always what is expected ... I would postpone this to the overall implementation of complete cascading anonymization, however. (tagged this comment explicitly in #220 now)
...app/core/common-components/entity-subrecord/entity-subrecord/entity-subrecord.component.html
Show resolved
Hide resolved
src/app/core/common-components/entity-subrecord/entity-subrecord/entity-subrecord.component.ts
Show resolved
Hide resolved
| @@ -562,15 +562,6 @@ export const defaultJsonConfig = { | |||
| ] | |||
| }, | |||
| "filters": [ | |||
| { | |||
There was a problem hiding this comment.
Needs a migration to remove this from all instances?
There was a problem hiding this comment.
yes, probably important - the filter will be broken with a default of showInactive = false automatically applied as well.
…-menu.component.ts Co-authored-by: Simon <simon@aam-digital.com>
Co-authored-by: Simon <simon@aam-digital.com>
Co-authored-by: Simon <simon@aam-digital.com>
Co-authored-by: Simon <simon@aam-digital.com>
Co-authored-by: Simon <simon@aam-digital.com>
# Conflicts: # src/app/core/common-components/entity-form/entity-form/entity-form.component.spec.ts # src/app/core/common-components/entity-form/entity-form/entity-form.component.ts
TheSlimvReal
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
It feels a little bit weird to talk give the annonymize option for recurring activities but then marking all fields as retain. Should we rather mark a whole entity as not-personal so that also the UI can hide this option and we don't have to worry about forgetting a property?
There was a problem hiding this comment.
yeah, actually had the exact same thought ... and for the cascading scenarios (#220 (comment)) we may need that also. Configuration options are growing explosively a bit, but I don't see good alternatives.
However, I think, I'd leave this as a TODO for the new PR.
|
🎉 This PR is included in version 3.26.0-master.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #1674 (and #899)
UX Changes
Tasks
somehow need to trigger an update to the entity details view after anonymizeimprove applyChanges of forms for entityUpdatescreate a new permissions "anonymize"