Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve default csv export #2033

Merged
merged 24 commits into from
Oct 31, 2023
Merged

Improve default csv export #2033

merged 24 commits into from
Oct 31, 2023

Conversation

brajesh-lab
Copy link
Contributor

@brajesh-lab brajesh-lab commented Oct 16, 2023 •
edited
Loading

closes: #1918

Visible/Frontend Changes

  • The column label is shown in the exported CSV file headers.

Architectural/Backend Changes

  • Added a new function to add column labels in the CSV file.

@github-actions
Copy link

Deployed to https://pr-2033.aam-digital.net/

@brajesh-lab brajesh-lab requested a review from sleidig October 17, 2023 14:30
@brajesh-lab brajesh-lab self-assigned this Oct 17, 2023
@brajesh-lab brajesh-lab marked this pull request as ready for review October 18, 2023 06:49
sleidig
sleidig requested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality works well 💯

A few remarks on fitting this into our software architecture in my comments.

src/app/core/export/download-service/download.service.ts Outdated Show resolved Hide resolved
src/app/core/entity-list/entity-list/entity-list.component.ts Outdated Show resolved Hide resolved
@brajesh-lab brajesh-lab requested a review from sleidig October 19, 2023 07:57
@brajesh-lab brajesh-lab requested a review from sleidig October 24, 2023 04:34
@brajesh-lab brajesh-lab requested a review from sleidig October 27, 2023 14:26
sleidig
sleidig approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the further improvements, @brajesh-lab .
Looks good to go now!

Do have a look at my last commit here to understand how I fixed your unit test syntax (( vs [)

@sleidig sleidig merged commit 58cd3a9 into master Oct 31, 2023
5 of 6 checks passed
@sleidig sleidig deleted the improve-default-csv-export branch October 31, 2023 09:07
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.26.0-master.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Oct 31, 2023
sleidig pushed a commit that referenced this pull request Nov 8, 2023
@brajesh-lab @sleidig
feat(export): export only human-readable fields and use better headers (
d1cb4e9 
#2033)

closes #1918

---------
Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

@rudresh rudresh rudresh left review comments

Assignees

@brajesh-lab brajesh-lab

Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve default CSV export
4 participants
@brajesh-lab @aam-digital-ci @rudresh @sleidig