Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept associations as inputs for array filters #303

Merged
merged 6 commits into from
Oct 2, 2015
Merged

Accept associations as inputs for array filters #303

merged 6 commits into from
Oct 2, 2015

Conversation

tfausak
Copy link
Collaborator

@tfausak tfausak commented Oct 1, 2015

This pull request will fix #301.

@tfausak tfausak added the bug label Oct 1, 2015
@tfausak tfausak self-assigned this Oct 1, 2015
@tfausak
Copy link
Collaborator Author

tfausak commented Oct 1, 2015

The specs are failing because the specs are using eql instead of eq. We started doing that in e454f1e. Collection proxies aren't eql to arrays, which is the root cause of #301.

Since we didn't really switch to eql for any particular reason, I think I'll change them over.

@tfausak
Use #eq instead of #eql for some checks
3f99236 
While it would be nice to use #eq, ActiveRecord's collection proxies
don't play nicely.
@tfausak
Copy link
Collaborator Author

tfausak commented Oct 1, 2015

Hmm, now the build is failing because sqlite3 won't build on JRuby.

@AaronLasseigne
Copy link
Owner

Can we just mock instead?

@tfausak
Copy link
Collaborator Author

tfausak commented Oct 2, 2015

We can! That worked well. Can you review these changes?

@AaronLasseigne
Copy link
Owner

👍

@tfausak tfausak merged commit bc58c6a into master Oct 2, 2015
@tfausak tfausak deleted the gh-301-associations branch October 2, 2015 16:02
tfausak added a commit that referenced this pull request Oct 2, 2015
@tfausak
Back port #303 to 2.0.x
b07c6fe
@tfausak tfausak mentioned this pull request Oct 2, 2015
Closed
tfausak added a commit that referenced this pull request Oct 2, 2015
@tfausak
Back port #303 to 1.6.x
24fce4b
@tfausak tfausak mentioned this pull request Oct 2, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tfausak tfausak

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation array with model
2 participants
@tfausak @AaronLasseigne