Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept associations as inputs for array filters #303

Merged
merged 6 commits into from
Oct 2, 2015
Merged

Accept associations as inputs for array filters #303

merged 6 commits into from
Oct 2, 2015

Commits on Oct 1, 2015

  1. Add some specs for relations

    @tfausak
    tfausak committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    e637882 View commit details
    Browse the repository at this point in the history

  2. Fix #301; allow passing collection proxies to array filters

    @tfausak
    tfausak committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    65bb577 View commit details
    Browse the repository at this point in the history

  3. Clean up #classes method

    @tfausak
    tfausak committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    8c30546 View commit details
    Browse the repository at this point in the history

  4. Use #safe_constantize 

    I forgot that we already depend on ActiveSupport.
    @tfausak
    tfausak committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    b9dae43 View commit details
    Browse the repository at this point in the history

  5. Use #eq instead of #eql for some checks 

    While it would be nice to use #eq, ActiveRecord's collection proxies
don't play nicely.
    @tfausak
    tfausak committed Oct 1, 2015
    Configuration menu
    Copy the full SHA
    3f99236 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2015

  1. Stub out ActiveRecord stuff in tests

    @tfausak
    tfausak committed Oct 2, 2015
    Configuration menu
    Copy the full SHA
    bc58c6a View commit details
    Browse the repository at this point in the history