Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from lobehub:main #187

Merged
merged 2 commits into from
Oct 13, 2024
Merged

[pull] main from lobehub:main #187

merged 2 commits into from
Oct 13, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Oct 13, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

cy948 and others added 2 commits October 13, 2024 15:47
### [Version 1.22.2](v1.22.1...v1.22.2)
<sup>Released on **2024-10-13**</sup>

#### 🐛 Bug Fixes

- **misc**: Allow use email as name in logto.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Allow use email as name in logto, closes [#4350](#4350) ([d5a046a](d5a046a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Copy link

cr-gpt bot commented Oct 13, 2024

Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information

Copy link

sourcery-ai bot commented Oct 13, 2024

Reviewer's Guide by Sourcery

This pull request introduces a minor bug fix to allow the use of email as a name in the Logto authentication provider. The changes are implemented in the CHANGELOG.md file to document the new version 1.22.2 and in the src/libs/next-auth/sso-providers/logto.ts file to modify the user profile mapping.

Class diagram for Logto authentication provider changes

classDiagram
    class LogtoProfile {
        +String email
        +String sub
        +String picture
        +String name
        +String username
    }
    class OIDCUserConfig {
        +LogtoProfile profile
    }
    class OIDCConfig {
        +String email
        +String id
        +String image
        +String name
        +String providerAccountId
    }
    OIDCUserConfig --> LogtoProfile
    OIDCConfig --> OIDCUserConfig
    note for OIDCConfig "Updated to use email as name if name and username are not available"
Loading

File-Level Changes

Change Details Files
Allow using email as name in Logto authentication
  • Add fallback to use email as name if name and username are not available
  • Update user profile mapping in LobeLogtoProvider function
src/libs/next-auth/sso-providers/logto.ts
Update CHANGELOG.md for version 1.22.2 CHANGELOG.md

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time. You can also use
    this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. It seems to have been created by a bot (hey, pull[bot]!). We assume it knows what it's doing!

@pull pull bot added the ⤵️ pull label Oct 13, 2024
@github-actions github-actions bot merged commit 5564623 into Abaso007:main Oct 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants