Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix: allow use email as name in logto #4350

Merged
merged 1 commit into from
Oct 13, 2024

Conversation

cy948
Copy link
Contributor

@cy948 cy948 commented Oct 13, 2024

💻 变更类型 | Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • 📝 docs
  • 🔨 chore

🔀 变更说明 | Description of Change

  • src/libs/next-auth/sso-providers/logto.ts: 使用 email 作为用户标识。

📝 补充信息 | Additional Information

Copy link

vercel bot commented Oct 13, 2024

@cy948 is attempting to deploy a commit to the LobeChat Community Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐛 Bug Something isn't working | 缺陷 labels Oct 13, 2024
@lobehubbot
Copy link
Member

👍 @cy948

Thank you for raising your pull request and contributing to our Community
Please make sure you have followed our contributing guidelines. We will review it as soon as possible.
If you encounter any problems, please feel free to connect with us.
非常感谢您提出拉取请求并为我们的社区做出贡献,请确保您已经遵循了我们的贡献指南,我们会尽快审查它。
如果您遇到任何问题,请随时与我们联系。

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.19%. Comparing base (c04afba) to head (0cc3937).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##             main    #4350     +/-   ##
=========================================
  Coverage   92.19%   92.19%             
=========================================
  Files         491      491             
  Lines       35349    35349             
  Branches     2300     3396   +1096     
=========================================
  Hits        32591    32591             
  Misses       2758     2758             
Flag Coverage Δ
app 92.19% <ø> (ø)
server 97.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arvinxx arvinxx merged commit d5a046a into lobehub:main Oct 13, 2024
5 of 7 checks passed
@lobehubbot
Copy link
Member

❤️ Great PR @cy948 ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.
项目的成长离不开用户反馈和贡献,感谢您的贡献! 如果您对 LobeHub 开发者社区感兴趣,请加入我们的 discord,然后私信 @arvinxx@canisminor1990。他们会邀请您加入我们的私密开发者频道。我们将会讨论关于 Lobe Chat 的开发,分享和讨论全球范围内的 AI 消息。

github-actions bot pushed a commit that referenced this pull request Oct 13, 2024
### [Version&nbsp;1.22.2](v1.22.1...v1.22.2)
<sup>Released on **2024-10-13**</sup>

#### 🐛 Bug Fixes

- **misc**: Allow use email as name in logto.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Allow use email as name in logto, closes [#4350](#4350) ([d5a046a](d5a046a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Member

🎉 This PR is included in version 1.22.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit to bentwnghk/lobe-chat that referenced this pull request Oct 13, 2024
### [Version&nbsp;1.65.1](v1.65.0...v1.65.1)
<sup>Released on **2024-10-13**</sup>

#### 🐛 Bug Fixes

- **misc**: Allow use email as name in logto.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's fixed

* **misc**: Allow use email as name in logto, closes [lobehub#4350](https://github.com/bentwnghk/lobe-chat/issues/4350) ([d5a046a](d5a046a))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working | 缺陷 released size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] logto 切换为mail注册后因为无username传入数据库,可以加入一个mail 作为标识嘛?
3 participants