Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/540 forward lineage #1091

Closed
wants to merge 10 commits into from
Closed

Conversation

dk1844
Copy link
Contributor

@dk1844 dk1844 commented Jul 14, 2022

Heavily inspired by (backward) Lineage. After the naive implementation, common parts of the foxx service have been moved to commons.js for reuse.

(Also, there is a similar PR #1092 - let's inspire each other, @vishalag001)

API

Spline service level API

GET /spline/events/$eventId/lineage-overview/$maxDepth

  • yields the impact (forward lineage) graph object

ArangoDB foxx-service level API

GET /events/:eventKey/impact-overview/:maxDepth

  • yields the impact (forward lineage) graph object (from persistence)

Test-run

I have hacked the spline-ui to load .../impact-overview url instead of .../lineage-overview to test the graph data in UI to be shown:

hacked-ui-to-show-impact-overview

Implements backed of #540.

@dk1844 dk1844 mentioned this pull request Jul 18, 2022
@dk1844
Copy link
Contributor Author

dk1844 commented Jul 18, 2022

@wajda @cerveada At this point, the solution seems to work. Is it worth, or rather, to what degree should I try to deduplicate with the original code - there are quite obviously some similar parts...?

@wajda
Copy link
Contributor

wajda commented Jul 18, 2022

@wajda @cerveada At this point, the solution seems to work. Is it worth, or rather, to what degree should I try to deduplicate with the original code - there are quite obviously some similar parts...?

It's up to you. Of course the code quality is important, and I don't think any AQL or FOXX code has any special additions or exceptions related to the common code quality standards. Just use a usual common sense. When you're done mark it as "ready for review" and we'll take a look.

@dk1844 dk1844 marked this pull request as ready for review July 20, 2022 12:32
@dk1844 dk1844 requested review from wajda and cerveada as code owners July 20, 2022 12:32
@cerveada
Copy link
Contributor

What is a purpose of the two empty files?

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dk1844
Copy link
Contributor Author

dk1844 commented Jul 22, 2022

What is a purpose of the two empty files?

After some digging, I have discovered that it was due to file mode being inadvertently changed - probably when sharing between Win-Linux/etc while having git's core.filemode enabled. Some details here. The default settings always changed my file mode even if I reverted any changes.

So I have set git config core.filemode false on my cloned repo on Windows and I have reverted the files to the original state 👍 . Thanks for noticing

@wajda wajda mentioned this pull request Jul 22, 2022
@dk1844
Copy link
Contributor Author

dk1844 commented Jul 26, 2022

Closed in favor of #1100

@dk1844 dk1844 closed this Jul 26, 2022
@wajda wajda deleted the feature/540-forward-lineage branch September 20, 2022 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants