Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward Lineage #1092

Closed
wants to merge 1 commit into from
Closed

Forward Lineage #1092

wants to merge 1 commit into from

Conversation

vishalag001
Copy link

Following up on the discussion: #1081
I created a new foxx service which gives the forward lineage for a given write event. I was able to visualise the forward lineage on the lineage overview page.

Attaching the screenshot of the same.

forwardLineage

The PR is for the backend change for the forward lineage.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dk1844
Copy link
Contributor

dk1844 commented Jul 18, 2022

Great work, @vishalag001, thank you for providing this!

I have actually been working on something similar and few days ago, I have started pushing this, too - in #1091.

I am sure, that we can learn from each other's codebases and finish the feature successfully, now, here or there! 🤝

@dk1844
Copy link
Contributor

dk1844 commented Jul 18, 2022

So have actually went through this PR and it is extremely similar to #1091 (mostly there is just difference in wording or file naming).

There is one important difference, though, it is how observedReadsByWrite are defined - not only we need to assess reads happening after the initial write, but also, we need to disregard read after a rewrite (since the lineage would get broken at that point)

@vishalag001, would you mind reviewing #1091, too?

@wajda
Copy link
Contributor

wajda commented Jul 18, 2022

I think we can close it in favour of #1091 if you guys don't mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants