Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added instantiate2 #309
Added instantiate2 #309
Changes from all commits
e8280d3
9fcacf7
a067de7
5f17584
b4a7b13
e731af1
4a2d9a7
0b63427
d8201cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 352 in cw-orch-daemon/src/core.rs
Codecov / codecov/patch
cw-orch-daemon/src/core.rs#L349-L352
Check warning on line 285 in cw-orch-daemon/src/queriers/cosmwasm.rs
Codecov / codecov/patch
cw-orch-daemon/src/queriers/cosmwasm.rs#L274-L285
Check warning on line 288 in cw-orch-daemon/src/queriers/cosmwasm.rs
Codecov / codecov/patch
cw-orch-daemon/src/queriers/cosmwasm.rs#L287-L288
Check warning on line 280 in cw-orch/src/osmosis_test_tube/core.rs
Codecov / codecov/patch
cw-orch/src/osmosis_test_tube/core.rs#L271-L280
Check warning on line 166 in cw-orch/src/osmosis_test_tube/queriers/wasm.rs
Codecov / codecov/patch
cw-orch/src/osmosis_test_tube/queriers/wasm.rs#L160-L166
Check warning on line 176 in cw-orch/src/osmosis_test_tube/queriers/wasm.rs
Codecov / codecov/patch
cw-orch/src/osmosis_test_tube/queriers/wasm.rs#L168-L176
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible to return (yet) not executed instantiate2 struct instead? Main use for instantiate2 will be knowing the address, before instantiating. I'm expecting experience to be something like:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand what you mean here ? You want a function that would return the instantiate2 addr if ever it was instantiated ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I want function that can return the address of pre-filled, but not executed instantiate2 message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using helpers such as https://docs.rs/cosmwasm-std/latest/cosmwasm_std/fn.instantiate2_address.html would be annoying, so I would prefer it to be as a part of API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK,implemented what we discussed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is now a method on the wasm querier correct?
Check warning on line 194 in packages/cw-orch-core/src/environment/cosmwasm_environment.rs
Codecov / codecov/patch
packages/cw-orch-core/src/environment/cosmwasm_environment.rs#L184-L194