Added instantiate2 #309
Merged
Added instantiate2 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying with
|
| Latest commit: |
d8201cd
|
| Status: | 🚫 Build failed. |
Buckram123
requested changes
Jan 15, 2024
Comment on lines
+49
to
+59
| /// Send a Instantiate2Msg to a contract. | ||
| fn instantiate2<I: Serialize + Debug>( | ||
| &self, | ||
| code_id: u64, | ||
| init_msg: &I, | ||
| label: Option<&str>, | ||
| admin: Option<&Addr>, | ||
| coins: &[cosmwasm_std::Coin], | ||
| salt: Binary, | ||
| ) -> Result<Self::Response, Self::Error>; | ||
|
|
There was a problem hiding this comment.
Is it possible to return (yet) not executed instantiate2 struct instead? Main use for instantiate2 will be knowing the address, before instantiating. I'm expecting experience to be something like:
let contract1 = chain.instantiate2(...)?;
let contract1_addr = contract1.addr()?;
let contract2 = chain.instantiate2(...)?;
let contract2_addr = contract2.addr()?;
// ...
contract1.submit(Contract1InstantiateMsg{
contract2_addr: contract2_addr.to_string()
})?;There was a problem hiding this comment.
I'm not sure I understand what you mean here ? You want a function that would return the instantiate2 addr if ever it was instantiated ?
There was a problem hiding this comment.
I'm not sure I understand what you mean here ? You want a function that would return the instantiate2 addr if ever it was instantiated ?
Yes, I want function that can return the address of pre-filled, but not executed instantiate2 message.
There was a problem hiding this comment.
Using helpers such as https://docs.rs/cosmwasm-std/latest/cosmwasm_std/fn.instantiate2_address.html would be annoying, so I would prefer it to be as a part of API
There was a problem hiding this comment.
OK,implemented what we discussed
There was a problem hiding this comment.
So this is now a method on the wasm querier correct?
Codecov ReportAttention:
Additional details and impacted files
|
CyberHoward
approved these changes
Feb 1, 2024
Kayanski
added a commit
that referenced
this pull request
Feb 5, 2024
* Added first queriers * Added bank + Wasm traits * Removed deprecated code * Lint * Format * Generalized querier getter (#318) * show POC of generalized querier getter * update * fix merge and impl for all envs * Doon't verify mockj error anymore * Fixed test * update `QueryHandler` and WasmQuerier functions * fix smart query URL * fix compile * format and clippy --------- Co-authored-by: Kayanski <kowalski.kowalskin@gmail.com> * Added instantiate2 (#309) * Added instantiate2 * some fixes * Added instantiate2 addr getter * Format * Nits * Merged daemon queriers * Corrected querier in tests * Renamed queriers * fix tests * Fix tests * Renamed trait types * Changed types for osmosis test tube * Feature fix * Removed unused querier traits, adapted all daemon queriers with same structure --------- Co-authored-by: CyberHoward <88450409+CyberHoward@users.noreply.github.com>
Kayanski
added a commit
that referenced
this pull request
Feb 5, 2024
* Added first queriers * Added bank + Wasm traits * Added cw-multi-test 0.20.0 * Removed secp, removed ibc-relayer-types * Removed ibc-relayer-types completely * updated prost typesé * Start testing authz * Added authz test * Removed deprecated code * Lint * Format * add authz querier * tx handler error with anyhow test * format * Added authz builder method for options * Some nits * Revert with_authz, added sender options setter * Check rest of authz queries * Added mock state env id * Added fee grant in daemon builder and interface * Format * fix find_wasm_path_with * Generalized querier getter (#318) * show POC of generalized querier getter * update * fix merge and impl for all envs * Doon't verify mockj error anymore * Fixed test * update `QueryHandler` and WasmQuerier functions * fix smart query URL * fix compile * format and clippy --------- Co-authored-by: Kayanski <kowalski.kowalskin@gmail.com> * Added instantiate2 (#309) * Added instantiate2 * some fixes * Added instantiate2 addr getter * Format * Nits * Merged daemon queriers * Corrected querier in tests * Renamed queriers * fix tests * Fix tests * Renamed trait types * Changed types for osmosis test tube * Fixed features --------- Co-authored-by: Buckram <buckram123@gmail.com> Co-authored-by: CyberHoward <88450409+CyberHoward@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at adding instantiate2 support directly inside the TxHandler trait
Closes ORC-62
Not using fix_msg because cosmwasm discourages it https://medium.com/cosmwasm/dev-note-3-limitations-of-instantiate2-and-how-to-deal-with-them-a3f946874230