Generalized querier getter

[CyberHoward]

This draft PR shows a different approach to querier construction and access.

Instead of having a Getter trait for each querier we have a single QuerierGetter trait that retrieves a querier Q. This querier Q implements a Querier trait. Both are shown below:

pub trait QuerierGetter<Q: Querier> {
    fn querier(&self) -> Q;
}

pub trait Querier {
    type Error: Into<CwEnvError> + Debug;
}

The inclusion of type Error in Querier prevents some duplicate code in the traits.

Now each querier trait needs to add Querier as its trait bound, like so:

pub trait BankQuerier: Querier {
    fn supply_of(&self, denom: impl Into<String>) -> Result<Coin, Self::Error>;
    // ...
}

To get allow for retrieving the querier we implement the QuerierGetter with a specified querier like so:

impl Querier for DaemonBankQuerier {
    type Error = DaemonError;
}

impl QuerierGetter<DaemonBankQuerier> for Daemon {
    fn querier(&self) -> DaemonBankQuerier {
        DaemonBankQuerier::new(self)
    }
}

We can then create arbitrary sets of supported queriers, like:

pub trait DefaultQueriers: QuerierGetter<Self::B> + QuerierGetter<Self::W> + QuerierGetter<Self::N> {
    type B: BankQuerier;
    type W: WasmQuerier;
    type N: NodeQuerier;

    fn bank_querier(&self) -> Self::B {
        self.querier()
    }

    fn wasm_querier(&self) -> Self::W {
        self.querier()
    }

    fn node_querier(&self) -> Self::N {
        self.querier()
    }
}

And use that as a trait-bound!

pub trait QueryHandler: DefaultQueriers {
  // ...
}

Thoughts?

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Pages

Latest commit:	2b78247
Status:	🚫  Build failed.

View logs

[CyberHoward]

@Kayanski do you prefer this over your original design? If so I can proceed with finalizing this.

[Kayanski]

@Kayanski do you prefer this over your original design? If so I can proceed with finalizing this.

yes this is a good idea !

[codecov]

Codecov Report

Attention: 266 lines in your changes are missing coverage. Please review.

Comparison is base (a990cbe) 66.2% compared to head (2b78247) 65.5%.
Report is 9 commits behind head on update/separate-query-tx.

Additional details and impacted files

Files	Coverage Δ
cw-orch-daemon/src/sync/core.rs	52.5% <100.0%> (-4.4%)	⬇️
...ges/cw-orch-core/src/contract/contract_instance.rs	78.4% <ø> (ø)
...ages/cw-orch-core/src/contract/interface_traits.rs	73.9% <100.0%> (+3.3%)	⬆️
...-orch-core/src/environment/cosmwasm_environment.rs	30.1% <100.0%> (+11.3%)	⬆️
...kages/cw-orch-core/src/environment/queriers/mod.rs	100.0% <100.0%> (ø)
...ages/cw-orch-core/src/environment/queriers/wasm.rs	100.0% <100.0%> (ø)
packages/cw-orch-core/src/environment/state.rs	55.5% <ø> (ø)
packages/cw-orch-mock/src/core.rs	93.3% <100.0%> (+5.8%)	⬆️
...kages/cw-orch-core/src/environment/queriers/env.rs	0.0% <0.0%> (ø)
packages/cw-orch-core/src/environment/mut_env.rs	0.0% <0.0%> (ø)
... and 16 more

... and 1 file with indirect coverage changes

[Kayanski]

Why this change, is it linting or manual ?

[CyberHoward]

It was giving me issues for some reason, don't know why

[Kayanski]

LGTM