Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial translation from standard_surface to open_pbr_surface #1934

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

mkuo-lucasfilm
Copy link
Contributor

  1. Authored an initial pass at the translation graph between standard surface and OpenPBR

  2. Added units to standard surface thin film thickness documentation

1. Authored an initial pass at the translation graph between standard surface and OpenPBR

2. Added units to standard surface thin film thickness documentation
@mkuo-lucasfilm
Copy link
Contributor Author

mkuo-lucasfilm commented Jul 12, 2024

Copper translation example from standard surface (top) to OpenPBR (bottom)
standard_surface_copper
standard_surface_copper_open_pbr

@mkuo-lucasfilm
Copy link
Contributor Author

Brass tiled example from standard surface (top) to OpenPBR (bottom)
standard_surface_brass
standard_surface_brass_open_pbr

@mkuo-lucasfilm
Copy link
Contributor Author

Car paint translation example from standard surface (top) to OpenPBR (bottom) - could be improved
standard_surface_carpaint
standard_surface_carpaint_open_pbr

@jstone-lucasfilm jstone-lucasfilm changed the title Standard_surface to open_pbr translation Initial translation from standard_surface to open_pbr_surface Jul 12, 2024
Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me, thanks @mkuo-lucasfilm, and I'd say that we should merge this to main, while still encouraging additional ideas and proposed improvements from the community.

@jstone-lucasfilm jstone-lucasfilm merged commit 5988645 into AcademySoftwareFoundation:main Jul 17, 2024
34 checks passed
JGamache-autodesk added a commit to autodesk-forks/MaterialX that referenced this pull request Nov 5, 2024
…Foundation#2087)

The standard_surface coat parameters are currently affecting the baseColor of UsdPreviewSurface. It should also affect emission color.

Initial translation from `open_pbr_surface` to `standard_surface` (AcademySoftwareFoundation#1949)

- Authored an initial pass at the translation from OpenPBR to standard surface.
- This would help to support OpenPBR in applications using earlier versions of MaterialX, which only have access to Standard Surface, but may want to participate in the OpenPBR ecosystem before they upgrade.

Update `standard_surface` to `open_pbr` translation graph   (AcademySoftwareFoundation#1956)

Replacing coat_affect_roughness with a constant value, since a coating always affects roughness in OpenPBR and is not dependent on the value of coat_darkening.

Improved `open_pbr_surface` to `standard_surface` translation (AcademySoftwareFoundation#1958)

Integrated the logic of coat_darkening from OpenPBR into the calculations of base_color and subsurface_color.

Initial translation from `standard_surface` to `open_pbr_surface` (AcademySoftwareFoundation#1934)

1. Authored an initial pass at the translation graph between standard surface and OpenPBR
2. Added units to standard surface thin film thickness documentation

Update documentation of OpenPBR and Standard Surface translations (AcademySoftwareFoundation#1963)

Clarified documentation where the motivation for the conversion might not be clear - both for the translation graph from OpenPBR to Standard Surface, and the translation graph from Standard Surface to OpenPBR.

Decrement translation graphs minor version (backport)

Consider subsurface color in dielectric albedo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants