-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial translation from open_pbr_surface
to standard_surface
#1949
Initial translation from open_pbr_surface
to standard_surface
#1949
Conversation
mkuo-lucasfilm
commented
Jul 24, 2024
- Authored an initial pass at the translation from OpenPBR to standard surface
- This would help to support OpenPBR in applications using earlier versions of MaterialX, which only have access to Standard Surface, but may want to participate in the OpenPBR ecosystem before they upgrade.
1. Authored an initial pass at the translation from OpenPBR to standard surface - This would help to support OpenPBR in applications using earlier versions of MaterialX, which only have access to Standard Surface, but may want to participate in the OpenPBR ecosystem before they upgrade.
Hi @mkuo-lucasfilm ,
Thanks. |
Good questions, @kwokcb, and I can provide some initial thoughts:
|
open_pbr_surface
to standard_surface
Signed-off-by: Jonathan Stone <jstone@lucasfilm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me, thanks @mkuo-lucasfilm!
55b52ec
into
AcademySoftwareFoundation:main
…Foundation#2087) The standard_surface coat parameters are currently affecting the baseColor of UsdPreviewSurface. It should also affect emission color. Initial translation from `open_pbr_surface` to `standard_surface` (AcademySoftwareFoundation#1949) - Authored an initial pass at the translation from OpenPBR to standard surface. - This would help to support OpenPBR in applications using earlier versions of MaterialX, which only have access to Standard Surface, but may want to participate in the OpenPBR ecosystem before they upgrade. Update `standard_surface` to `open_pbr` translation graph (AcademySoftwareFoundation#1956) Replacing coat_affect_roughness with a constant value, since a coating always affects roughness in OpenPBR and is not dependent on the value of coat_darkening. Improved `open_pbr_surface` to `standard_surface` translation (AcademySoftwareFoundation#1958) Integrated the logic of coat_darkening from OpenPBR into the calculations of base_color and subsurface_color. Initial translation from `standard_surface` to `open_pbr_surface` (AcademySoftwareFoundation#1934) 1. Authored an initial pass at the translation graph between standard surface and OpenPBR 2. Added units to standard surface thin film thickness documentation Update documentation of OpenPBR and Standard Surface translations (AcademySoftwareFoundation#1963) Clarified documentation where the motivation for the conversion might not be clear - both for the translation graph from OpenPBR to Standard Surface, and the translation graph from Standard Surface to OpenPBR. Decrement translation graphs minor version (backport) Consider subsurface color in dielectric albedo